From: Peter Xu <peterx@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com,
vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com,
cornelia.huck@de.ibm.com, dgibson@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add
Date: Mon, 12 Sep 2016 13:54:24 +0800 [thread overview]
Message-ID: <20160912055424.GD3776@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160912011737.GB12621@voom.fritz.box>
On Mon, Sep 12, 2016 at 11:17:37AM +1000, David Gibson wrote:
[...]
> > I think now I understand the point... Then I'd prefer to use David's
> > suggestion. A single notify_changed() looks cleaner. To be more
> > explicit, I would prefer to rename it to notifier_flag_changed(),
> > since notify_changed() looks like to be called every time notifier
> > list changed, but actually it is for monitoring the flags.
>
> That sounds reasonable. I think notifier_flag_changed() should be
> passed both the old and new flags, to save the backend having to keep
> track of the old ones - which flags have changed might affect what the
> callback needs to do.
Agree. That's exactly what v4 was doing. Thanks,
-- peterx
next prev parent reply other threads:[~2016-09-12 5:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 5:32 [Qemu-devel] [PATCH v3 0/3] Introduce IOMMUNotifier struct Peter Xu
2016-09-07 5:32 ` [Qemu-devel] [PATCH v3 1/3] memory: introduce IOMMUNotifier and its caps Peter Xu
2016-09-07 6:02 ` David Gibson
2016-09-07 7:09 ` Peter Xu
2016-09-07 10:20 ` David Gibson
2016-09-08 10:00 ` Peter Xu
2016-09-07 5:32 ` [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add Peter Xu
2016-09-07 6:05 ` David Gibson
2016-09-07 7:23 ` Peter Xu
2016-09-07 10:23 ` David Gibson
2016-09-07 10:54 ` Paolo Bonzini
2016-09-08 10:22 ` Peter Xu
2016-09-12 1:17 ` David Gibson
2016-09-12 5:54 ` Peter Xu [this message]
2016-09-07 5:32 ` [Qemu-devel] [PATCH v3 3/3] intel_iommu: allow invalidation typed notifiers Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912055424.GD3776@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vkaplans@redhat.com \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.