From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: Regmap regression in next caused by of_iomap change Date: Mon, 12 Sep 2016 09:55:27 +0100 Message-ID: <20160912085527.GA1873@dell> References: <20160908184111.vj3sb2ik6ydehkag@atomide.com> <4088076.eNNe5WgnxT@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4088076.eNNe5WgnxT@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Tony Lindgren , Andrey Smirnov , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gVGh1LCAwOCBTZXAgMjAxNiwgQXJuZCBCZXJnbWFubiB3cm90ZToKCj4gT24gVGh1cnNkYXks IFNlcHRlbWJlciA4LCAyMDE2IDExOjQxOjEyIEFNIENFU1QgVG9ueSBMaW5kZ3JlbiB3cm90ZToK PiA+IEhpLAo+ID4gCj4gPiBMb29rcyBsaWtlIGNvbW1pdCAzOWRlMmM0Mjc1YTkgKCJtZmQ6IHN5 c2NvbjogTWFrZSB1c2Ugb2Ygb2ZfaW9tYXAiKQo+ID4gbWFrZXMgYXQgbGVhc3QgTU1DIFBCSUFT IHJlZ3VsYXRvciBzdG9wIHdvcmtpbmcgb24gb21hcDMuCj4gPgo+ID4gVGhhdCdzIHByb2JhYmx5 IGJlY2F1c2Ugb2Zfc3lzY29uX3JlZ2lzdGVyIHVzZXMgdGhlIG5vdyB1bmludGlhbGl6ZWQKPiA+ IHN0cnVjdCByZXNvdXJjZSByZXMgdG8gc2V0IHN5c2Nvbl9jb25maWcubWF4X3JlZ2lzdGVyLgo+ IAo+IExvb2tzIGNvcnJlY3QuIExlZSwgcGxlYXNlIHNlbmQgYSByZXZlcnQgb2YgdGhhdCBwYXRj aCB0byBMaW51cwo+IGFsb25nIHdpdGggYW55IG90aGVyIGZpeGVzIHlvdSBtYXkgaGF2ZS4KCk5v IG5lZWQuICBJdCdzIG5vdCBpbiBNYWlubGluZS4KCj4gPiBJIGhhdmUgYSBzdHJhbmdlIGRlamEg dnUgZmVlbGluZyB0aGF0IHdlJ3ZlIGJlZW4gdGhyb3VnaCB0aGlzCj4gPiBiZWZvcmUgIFNlZSBj b21taXQgY2E2NjhmMGVkZmFlICgibWZkOiBzeXNjb246IFNldCByZWdtYXAgbWF4X3JlZ2lzdGVy Cj4gPiBpbiBvZl9zeXNjb25fcmVnaXN0ZXIiKQo+ID4gCj4gPiBNYXliZSB3ZSBzaG91bGQgYWRk IGNvbW1lbnRzIHRoZXJlIGluc3RlYWQ/Cj4gCj4gSSB3b25kZXIgd2h5IGdjYyBkaWRuJ3QgZGV0 ZWN0IHRoaXMgY2FzZS4gSSB1c3VhbGx5IGRvIG15Cj4gdGVzdCBidWlsZHMgd2l0aCAtV21heWJl LXVuaW5pdGlhbGl6ZWQgdGhhdCBzaG91bGQgaGF2ZQo+IGNhdWdodCBpdCBidXQgZGlkbid0LgoK LS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFk CkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cg TGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 12 Sep 2016 09:55:27 +0100 Subject: Regmap regression in next caused by of_iomap change In-Reply-To: <4088076.eNNe5WgnxT@wuerfel> References: <20160908184111.vj3sb2ik6ydehkag@atomide.com> <4088076.eNNe5WgnxT@wuerfel> Message-ID: <20160912085527.GA1873@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 08 Sep 2016, Arnd Bergmann wrote: > On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote: > > Hi, > > > > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap") > > makes at least MMC PBIAS regulator stop working on omap3. > > > > That's probably because of_syscon_register uses the now unintialized > > struct resource res to set syscon_config.max_register. > > Looks correct. Lee, please send a revert of that patch to Linus > along with any other fixes you may have. No need. It's not in Mainline. > > I have a strange deja vu feeling that we've been through this > > before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register > > in of_syscon_register") > > > > Maybe we should add comments there instead? > > I wonder why gcc didn't detect this case. I usually do my > test builds with -Wmaybe-uninitialized that should have > caught it but didn't. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog