From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C91A1A1E0A for ; Mon, 12 Sep 2016 02:59:05 -0700 (PDT) Received: by mail-lf0-x243.google.com with SMTP id l131so5628767lfl.0 for ; Mon, 12 Sep 2016 02:59:05 -0700 (PDT) Date: Mon, 12 Sep 2016 12:59:00 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly Message-ID: <20160912095900.GA23346@node.shutemov.name> References: <1473459863-11287-1-git-send-email-toshi.kani@hpe.com> <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Toshi Kani Cc: linux-nvdimm@lists.01.org, mawilcox@microsoft.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com List-ID: On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote: > shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly, > which leads to a reversed effect of "huge=" mount option. > > Fix the check in shmem_get_unmapped_area(). > > Note, the default value of SHMEM_SB(sb)->huge remains as > SHMEM_HUGE_NEVER. User will need to specify "huge=" option to > enable huge page mappings. > > Reported-by: Hillf Danton > Signed-off-by: Toshi Kani > Cc: Andrew Morton > Cc: Kirill A. Shutemov > Cc: Hugh Dickins Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f71.google.com (mail-lf0-f71.google.com [209.85.215.71]) by kanga.kvack.org (Postfix) with ESMTP id C55306B0038 for ; Mon, 12 Sep 2016 05:59:04 -0400 (EDT) Received: by mail-lf0-f71.google.com with SMTP id s64so92232395lfs.1 for ; Mon, 12 Sep 2016 02:59:04 -0700 (PDT) Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com. [2a00:1450:4010:c07::244]) by mx.google.com with ESMTPS id i201si6369196lfe.238.2016.09.12.02.59.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Sep 2016 02:59:03 -0700 (PDT) Received: by mail-lf0-x244.google.com with SMTP id s29so5571072lfg.3 for ; Mon, 12 Sep 2016 02:59:03 -0700 (PDT) Date: Mon, 12 Sep 2016 12:59:00 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly Message-ID: <20160912095900.GA23346@node.shutemov.name> References: <1473459863-11287-1-git-send-email-toshi.kani@hpe.com> <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, mawilcox@microsoft.com, hughd@google.com, kirill.shutemov@linux.intel.com, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote: > shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly, > which leads to a reversed effect of "huge=" mount option. > > Fix the check in shmem_get_unmapped_area(). > > Note, the default value of SHMEM_SB(sb)->huge remains as > SHMEM_HUGE_NEVER. User will need to specify "huge=" option to > enable huge page mappings. > > Reported-by: Hillf Danton > Signed-off-by: Toshi Kani > Cc: Andrew Morton > Cc: Kirill A. Shutemov > Cc: Hugh Dickins Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932501AbcILJ7s (ORCPT ); Mon, 12 Sep 2016 05:59:48 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35450 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757737AbcILJ7E (ORCPT ); Mon, 12 Sep 2016 05:59:04 -0400 Date: Mon, 12 Sep 2016 12:59:00 +0300 From: "Kirill A. Shutemov" To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, mawilcox@microsoft.com, hughd@google.com, kirill.shutemov@linux.intel.com, linux-nvdimm@ml01.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly Message-ID: <20160912095900.GA23346@node.shutemov.name> References: <1473459863-11287-1-git-send-email-toshi.kani@hpe.com> <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote: > shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly, > which leads to a reversed effect of "huge=" mount option. > > Fix the check in shmem_get_unmapped_area(). > > Note, the default value of SHMEM_SB(sb)->huge remains as > SHMEM_HUGE_NEVER. User will need to specify "huge=" option to > enable huge page mappings. > > Reported-by: Hillf Danton > Signed-off-by: Toshi Kani > Cc: Andrew Morton > Cc: Kirill A. Shutemov > Cc: Hugh Dickins Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov