From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Adit Ranadive <aditr@vmware.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, jhansen@vmware.com,
asarwade@vmware.com, georgezhang@vmware.com, bryantan@vmware.com
Subject: Re: [PATCH v4 02/16] IB/pvrdma: Add user-level shared functions
Date: Mon, 12 Sep 2016 11:49:34 -0600 [thread overview]
Message-ID: <20160912174934.GE5843@obsidianresearch.com> (raw)
In-Reply-To: <1473655766-31628-3-git-send-email-aditr@vmware.com>
On Sun, Sep 11, 2016 at 09:49:12PM -0700, Adit Ranadive wrote:
> We share some common structures with the user-level driver. This patch
> adds those structures and shared functions to traverse the QP/CQ rings.
> create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_uapi.h
> create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_user.h
The files that are intended to be shared with userspace must be under
include/uapi/, please coordinate with Leon on the path.
Same for all the new drivers.
> +static inline __s32 pvrdma_idx(atomic_t *var, __u32 max_elems)
> +{
> + const unsigned int idx = atomic_read(var);
Eh? Does this even compile in userspace?
If this is not a userspace header then why does it use __u32 and
related ??
> +#define PVRDMA_UVERBS_ABI_VERSION 3
> +#define PVRDMA_BOARD_ID 1
> +#define PVRDMA_REV_ID 1
> +
> +struct pvrdma_alloc_ucontext_resp {
> + u32 qp_tab_size;
> + u32 reserved;
> +};
This certainly looks like a userspace header, shouldn't it use __u32?
NAK
Jason
next prev parent reply other threads:[~2016-09-12 17:49 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 4:49 [PATCH v4 00/16] Add Paravirtual RDMA Driver Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 17:21 ` Bjorn Helgaas
2016-09-12 17:21 ` Bjorn Helgaas
2016-09-14 11:08 ` Yuval Shaia
2016-09-14 16:00 ` Adit Ranadive
2016-09-14 16:00 ` Adit Ranadive
2016-09-14 16:24 ` Yuval Shaia
2016-09-14 19:36 ` Adit Ranadive
2016-09-14 19:36 ` Adit Ranadive
2016-09-15 7:55 ` Yuval Shaia
2016-09-20 13:37 ` Bjorn Helgaas
2016-09-20 13:37 ` Bjorn Helgaas
2016-09-12 4:49 ` [PATCH v4 02/16] IB/pvrdma: Add user-level shared functions Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 17:49 ` Jason Gunthorpe [this message]
2016-09-12 4:49 ` [PATCH v4 03/16] IB/pvrdma: Add virtual device RDMA structures Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 17:50 ` Jason Gunthorpe
2016-09-12 4:49 ` [PATCH v4 04/16] IB/pvrdma: Add the paravirtual RDMA device specification Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 12:28 ` Yuval Shaia
2016-09-14 12:49 ` Christoph Hellwig
2016-09-14 12:49 ` Christoph Hellwig
2016-09-15 0:10 ` Adit Ranadive
2016-09-15 0:10 ` Adit Ranadive
2016-09-15 6:15 ` Christoph Hellwig
2016-09-15 6:15 ` Christoph Hellwig
2016-09-15 7:15 ` Leon Romanovsky
2016-09-12 4:49 ` [PATCH v4 06/16] IB/pvrdma: Add paravirtual rdma device Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 11:17 ` Yuval Shaia
2016-09-14 11:17 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 07/16] IB/pvrdma: Add helper functions Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 11:21 ` Yuval Shaia
2016-09-14 11:21 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 08/16] IB/pvrdma: Add device command support Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 12:43 ` Yuval Shaia
2016-09-15 0:07 ` Adit Ranadive
2016-09-15 0:07 ` Adit Ranadive
2016-09-15 7:36 ` Yuval Shaia
2016-09-18 17:07 ` Leon Romanovsky
2016-09-18 20:36 ` Adit Ranadive
2016-09-18 20:36 ` Adit Ranadive
2016-09-19 3:24 ` Leon Romanovsky
2016-09-19 3:24 ` Leon Romanovsky
2016-09-12 4:49 ` [PATCH v4 10/16] IB/pvrdma: Add UAR support Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 11/16] IB/pvrdma: Add support for memory regions Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 12:46 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 12/16] IB/pvrdma: Add Queue Pair support Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 16:32 ` Yuval Shaia
2016-09-14 16:32 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 13/16] IB/pvrdma: Add the main driver module for PVRDMA Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-14 16:38 ` Yuval Shaia
2016-09-14 16:38 ` Yuval Shaia
2016-09-12 4:49 ` [PATCH v4 14/16] IB/pvrdma: Add Kconfig and Makefile Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 4:49 ` [PATCH v4 15/16] IB: Add PVRDMA driver Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 7:32 ` kbuild test robot
2016-09-12 7:32 ` kbuild test robot
2016-09-12 7:32 ` kbuild test robot
2016-09-12 9:00 ` kbuild test robot
2016-09-12 9:00 ` kbuild test robot
2016-09-12 9:00 ` kbuild test robot
2016-09-12 4:49 ` [PATCH v4 16/16] MAINTAINERS: Update for " Adit Ranadive
2016-09-12 4:49 ` Adit Ranadive
2016-09-12 17:52 ` Jason Gunthorpe
2016-09-12 22:13 ` Adit Ranadive
2016-09-12 22:13 ` Adit Ranadive
2016-09-15 7:27 ` Leon Romanovsky
2016-09-12 18:02 ` [PATCH v4 00/16] Add Paravirtual RDMA Driver Jason Gunthorpe
2016-09-12 22:43 ` Adit Ranadive
2016-09-12 22:43 ` Adit Ranadive
2016-09-12 23:16 ` Jason Gunthorpe
2016-09-12 23:16 ` Jason Gunthorpe
2016-09-14 17:36 ` Jason Gunthorpe
2016-09-14 19:44 ` Adit Ranadive
2016-09-14 19:44 ` Adit Ranadive
2016-09-14 20:50 ` Jason Gunthorpe
2016-09-14 22:03 ` Woodruff, Robert J
2016-09-14 22:20 ` Woodruff, Robert J
2016-09-14 22:59 ` Jason Gunthorpe
2016-09-14 22:59 ` Jason Gunthorpe
2016-09-16 16:32 ` Jason Gunthorpe
2016-09-16 16:43 ` Woodruff, Robert J
2016-09-15 7:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912174934.GE5843@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=aditr@vmware.com \
--cc=asarwade@vmware.com \
--cc=bryantan@vmware.com \
--cc=dledford@redhat.com \
--cc=georgezhang@vmware.com \
--cc=jhansen@vmware.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.