From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Mon, 12 Sep 2016 19:27:31 +0000 Subject: Re: [PATCH 10/26] tpm: constify local structures Message-Id: <20160912192731.GA3186@intel.com> List-Id: References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Peter Huewe , joe@perches.com, kernel-janitors@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 03:05:52PM +0200, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall Applied to the tip of my tree: http://git.infradead.org/users/jjs/linux-tpmdd.git/log Thanks for the good work! /Jarkko > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/char/tpm/tpm-interface.c | 10 +++++----- > drivers/char/tpm/tpm-sysfs.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index 1abe2d7..e84888f 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -633,7 +633,7 @@ EXPORT_SYMBOL_GPL(tpm_get_timeouts); > #define TPM_ORD_CONTINUE_SELFTEST 83 > #define CONTINUE_SELFTEST_RESULT_SIZE 10 > > -static struct tpm_input_header continue_selftest_header = { > +static const struct tpm_input_header continue_selftest_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = cpu_to_be32(TPM_ORD_CONTINUE_SELFTEST), > @@ -659,7 +659,7 @@ static int tpm_continue_selftest(struct tpm_chip *chip) > > #define TPM_ORDINAL_PCRREAD cpu_to_be32(21) > #define READ_PCR_RESULT_SIZE 30 > -static struct tpm_input_header pcrread_header = { > +static const struct tpm_input_header pcrread_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORDINAL_PCRREAD > @@ -745,7 +745,7 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > */ > #define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > #define EXTEND_PCR_RESULT_SIZE 34 > -static struct tpm_input_header pcrextend_header = { > +static const struct tpm_input_header pcrextend_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(34), > .ordinal = TPM_ORD_PCR_EXTEND > @@ -949,7 +949,7 @@ EXPORT_SYMBOL_GPL(wait_for_tpm_stat); > #define TPM_ORD_SAVESTATE cpu_to_be32(152) > #define SAVESTATE_RESULT_SIZE 10 > > -static struct tpm_input_header savestate_header = { > +static const struct tpm_input_header savestate_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = TPM_ORD_SAVESTATE > @@ -1032,7 +1032,7 @@ int tpm_pm_resume(struct device *dev) > EXPORT_SYMBOL_GPL(tpm_pm_resume); > > #define TPM_GETRANDOM_RESULT_SIZE 18 > -static struct tpm_input_header tpm_getrandom_header = { > +static const struct tpm_input_header tpm_getrandom_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORD_GET_RANDOM > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c > index b46cf70..26fccad 100644 > --- a/drivers/char/tpm/tpm-sysfs.c > +++ b/drivers/char/tpm/tpm-sysfs.c > @@ -22,7 +22,7 @@ > > #define READ_PUBEK_RESULT_SIZE 314 > #define TPM_ORD_READPUBEK cpu_to_be32(124) > -static struct tpm_input_header tpm_readpubek_header = { > +static const struct tpm_input_header tpm_readpubek_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(30), > .ordinal = TPM_ORD_READPUBEK > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 10/26] tpm: constify local structures Date: Mon, 12 Sep 2016 22:27:31 +0300 Message-ID: <20160912192731.GA3186@intel.com> References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1473599168-30561-11-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Julia Lawall Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Sep 11, 2016 at 03:05:52PM +0200, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall Applied to the tip of my tree: http://git.infradead.org/users/jjs/linux-tpmdd.git/log Thanks for the good work! /Jarkko > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/char/tpm/tpm-interface.c | 10 +++++----- > drivers/char/tpm/tpm-sysfs.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index 1abe2d7..e84888f 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -633,7 +633,7 @@ EXPORT_SYMBOL_GPL(tpm_get_timeouts); > #define TPM_ORD_CONTINUE_SELFTEST 83 > #define CONTINUE_SELFTEST_RESULT_SIZE 10 > > -static struct tpm_input_header continue_selftest_header = { > +static const struct tpm_input_header continue_selftest_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = cpu_to_be32(TPM_ORD_CONTINUE_SELFTEST), > @@ -659,7 +659,7 @@ static int tpm_continue_selftest(struct tpm_chip *chip) > > #define TPM_ORDINAL_PCRREAD cpu_to_be32(21) > #define READ_PCR_RESULT_SIZE 30 > -static struct tpm_input_header pcrread_header = { > +static const struct tpm_input_header pcrread_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORDINAL_PCRREAD > @@ -745,7 +745,7 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > */ > #define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > #define EXTEND_PCR_RESULT_SIZE 34 > -static struct tpm_input_header pcrextend_header = { > +static const struct tpm_input_header pcrextend_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(34), > .ordinal = TPM_ORD_PCR_EXTEND > @@ -949,7 +949,7 @@ EXPORT_SYMBOL_GPL(wait_for_tpm_stat); > #define TPM_ORD_SAVESTATE cpu_to_be32(152) > #define SAVESTATE_RESULT_SIZE 10 > > -static struct tpm_input_header savestate_header = { > +static const struct tpm_input_header savestate_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = TPM_ORD_SAVESTATE > @@ -1032,7 +1032,7 @@ int tpm_pm_resume(struct device *dev) > EXPORT_SYMBOL_GPL(tpm_pm_resume); > > #define TPM_GETRANDOM_RESULT_SIZE 18 > -static struct tpm_input_header tpm_getrandom_header = { > +static const struct tpm_input_header tpm_getrandom_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORD_GET_RANDOM > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c > index b46cf70..26fccad 100644 > --- a/drivers/char/tpm/tpm-sysfs.c > +++ b/drivers/char/tpm/tpm-sysfs.c > @@ -22,7 +22,7 @@ > > #define READ_PUBEK_RESULT_SIZE 314 > #define TPM_ORD_READPUBEK cpu_to_be32(124) > -static struct tpm_input_header tpm_readpubek_header = { > +static const struct tpm_input_header tpm_readpubek_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(30), > .ordinal = TPM_ORD_READPUBEK > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757774AbcILT1h (ORCPT ); Mon, 12 Sep 2016 15:27:37 -0400 Received: from mga05.intel.com ([192.55.52.43]:24912 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbcILT1f (ORCPT ); Mon, 12 Sep 2016 15:27:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,324,1470726000"; d="scan'208";a="7549456" Date: Mon, 12 Sep 2016 22:27:31 +0300 From: Jarkko Sakkinen To: Julia Lawall Cc: Peter Huewe , joe@perches.com, kernel-janitors@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/26] tpm: constify local structures Message-ID: <20160912192731.GA3186@intel.com> References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473599168-30561-11-git-send-email-Julia.Lawall@lip6.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 03:05:52PM +0200, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall Applied to the tip of my tree: http://git.infradead.org/users/jjs/linux-tpmdd.git/log Thanks for the good work! /Jarkko > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/char/tpm/tpm-interface.c | 10 +++++----- > drivers/char/tpm/tpm-sysfs.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index 1abe2d7..e84888f 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -633,7 +633,7 @@ EXPORT_SYMBOL_GPL(tpm_get_timeouts); > #define TPM_ORD_CONTINUE_SELFTEST 83 > #define CONTINUE_SELFTEST_RESULT_SIZE 10 > > -static struct tpm_input_header continue_selftest_header = { > +static const struct tpm_input_header continue_selftest_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = cpu_to_be32(TPM_ORD_CONTINUE_SELFTEST), > @@ -659,7 +659,7 @@ static int tpm_continue_selftest(struct tpm_chip *chip) > > #define TPM_ORDINAL_PCRREAD cpu_to_be32(21) > #define READ_PCR_RESULT_SIZE 30 > -static struct tpm_input_header pcrread_header = { > +static const struct tpm_input_header pcrread_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORDINAL_PCRREAD > @@ -745,7 +745,7 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > */ > #define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > #define EXTEND_PCR_RESULT_SIZE 34 > -static struct tpm_input_header pcrextend_header = { > +static const struct tpm_input_header pcrextend_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(34), > .ordinal = TPM_ORD_PCR_EXTEND > @@ -949,7 +949,7 @@ EXPORT_SYMBOL_GPL(wait_for_tpm_stat); > #define TPM_ORD_SAVESTATE cpu_to_be32(152) > #define SAVESTATE_RESULT_SIZE 10 > > -static struct tpm_input_header savestate_header = { > +static const struct tpm_input_header savestate_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(10), > .ordinal = TPM_ORD_SAVESTATE > @@ -1032,7 +1032,7 @@ int tpm_pm_resume(struct device *dev) > EXPORT_SYMBOL_GPL(tpm_pm_resume); > > #define TPM_GETRANDOM_RESULT_SIZE 18 > -static struct tpm_input_header tpm_getrandom_header = { > +static const struct tpm_input_header tpm_getrandom_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(14), > .ordinal = TPM_ORD_GET_RANDOM > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c > index b46cf70..26fccad 100644 > --- a/drivers/char/tpm/tpm-sysfs.c > +++ b/drivers/char/tpm/tpm-sysfs.c > @@ -22,7 +22,7 @@ > > #define READ_PUBEK_RESULT_SIZE 314 > #define TPM_ORD_READPUBEK cpu_to_be32(124) > -static struct tpm_input_header tpm_readpubek_header = { > +static const struct tpm_input_header tpm_readpubek_header = { > .tag = TPM_TAG_RQU_COMMAND, > .length = cpu_to_be32(30), > .ordinal = TPM_ORD_READPUBEK >