From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox systems platform Date: Tue, 13 Sep 2016 10:12:12 +0200 Message-ID: <20160913081212.GA15715@kroah.com> References: <20160912074059.GA19325@kroah.com> <20160912081712.GA27368@kroah.com> <20160912083436.GA9490@kroah.com> <20160912102124.GA3809@kroah.com> <20160912110053.GA5463@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60917 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbcIMIMG (ORCPT ); Tue, 13 Sep 2016 04:12:06 -0400 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Vadim Pasternak Cc: Ingo Molnar , Geert Uytterhoeven , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "mchehab@kernel.org" , "linux@roeck-us.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" On Tue, Sep 13, 2016 at 07:27:20AM +0000, Vadim Pasternak wrote: > > > > -----Original Message----- > > From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo > > Molnar > > Sent: Monday, September 12, 2016 2:01 PM > > To: Greg KH > > Cc: Geert Uytterhoeven ; Vadim Pasternak > > ; tglx@linutronix.de; mingo@redhat.com; > > hpa@zytor.com; davem@davemloft.net; akpm@linux-foundation.org; > > kvalo@codeaurora.org; mchehab@kernel.org; linux@roeck-us.net; > > x86@kernel.org; linux-kernel@vger.kernel.org; platform-driver- > > x86@vger.kernel.org; jiri@resnulli.us > > Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox > > systems platform > > > > > > * Greg KH wrote: > > > > > On Mon, Sep 12, 2016 at 11:14:26AM +0200, Geert Uytterhoeven wrote: > > > > On Mon, Sep 12, 2016 at 10:34 AM, Greg KH > > wrote: > > > > >> This is LPC to I2C bridge. > > > > > > > > > > "LPC"? > > > > > > > > https://en.wikipedia.org/wiki/Low_Pin_Count > > > > > > > > "Modern ISA" > > > > > > So my original point stands, 1990's technology being used for brand > > > new devices today, ugh :( > > > > > > Someone needs to go kick some hardware designers... > > > > In their defense, "this is a carbon copy of published 1990s technology" is a pretty > > good starting point for a defendant, in patent litigation. > > > > I understood your comments regarding undiscoverable busses. > But we use LPC on all our x86 based systems. > I have to activate all platform related stuff from some place and we > don't support ACPI. x86 that doesn't support ACPI? That's sad :( > Do you think it would be OK, if I'll remove all PCI related code, make > use of DMI and leave only platform activation code? > If yes, I'll re-work this driver and re-send it for your review. Yes, that sounds like a good start, let's see how the code looks after doing that. thanks, greg k-h