From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjjvR-0007SU-AY for qemu-devel@nongnu.org; Tue, 13 Sep 2016 05:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjjvN-0004Yi-5s for qemu-devel@nongnu.org; Tue, 13 Sep 2016 05:22:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjjvN-0004YG-0O for qemu-devel@nongnu.org; Tue, 13 Sep 2016 05:22:41 -0400 Date: Tue, 13 Sep 2016 10:22:34 +0100 From: "Daniel P. Berrange" Message-ID: <20160913092234.GE30949@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-4-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1473738741-220600-4-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, peter.huangpeng@huawei.com, luonengjun@huawei.com, mst@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de, xin.zeng@intel.com, claudio.fontana@huawei.com, nmorey@kalray.eu, vincent.jardin@6wind.com On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote: > In previous patch, we define CryptoLegacyHWOptions in > qapi-schema.json. we introduce the new/delete funciton > about crypto legacy hardware device. Isn't virtio-crypto / cryptodev an entirely new specification ? I'm surprised to be seeing something completely new described as "legacy". Can you explain this in more detail. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|