From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjke2-0001Wd-Qo for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjkdy-0003W1-Fi for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:08:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjkdy-0003Vr-7a for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:08:46 -0400 Date: Tue, 13 Sep 2016 11:08:40 +0100 From: "Daniel P. Berrange" Message-ID: <20160913100839.GM30949@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-4-git-send-email-arei.gonglei@huawei.com> <20160913092234.GE30949@redhat.com> <33183CC9F5247A488A2544077AF19020B03CA2E0@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020B03CA2E0@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Huangpeng (Peter)" , Luonengjun , "mst@redhat.com" , "stefanha@redhat.com" , "pbonzini@redhat.com" , "Huangweidong (C)" , "mike.caraman@nxp.com" , "agraf@suse.de" , "xin.zeng@intel.com" , Claudio Fontana , "nmorey@kalray.eu" , "vincent.jardin@6wind.com" On Tue, Sep 13, 2016 at 10:05:01AM +0000, Gonglei (Arei) wrote: > > > > -----Original Message----- > > From: Daniel P. Berrange [mailto:berrange@redhat.com] > > Sent: Tuesday, September 13, 2016 5:23 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > > (Peter); Luonengjun; mst@redhat.com; stefanha@redhat.com; > > pbonzini@redhat.com; Huangweidong (C); mike.caraman@nxp.com; > > agraf@suse.de; xin.zeng@intel.com; Claudio Fontana; nmorey@kalray.eu; > > vincent.jardin@6wind.com > > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff > > > > On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote: > > > In previous patch, we define CryptoLegacyHWOptions in > > > qapi-schema.json. we introduce the new/delete funciton > > > about crypto legacy hardware device. > > > > Isn't virtio-crypto / cryptodev an entirely new specification ? > > Yes, it's an complete new device. > > > I'm surprised to be seeing something completely new described > > as "legacy". Can you explain this in more detail. > > > Because there are two kind of crypto device, one is virtio-crypto which is > a virtual crypto device (And virtio-crypto device is a real crypto device seen by the guest). > The other is cryptodev backend device. I have no good idea to name the kind > of virtio-crypto device, so named to legacy crypto device refer to Net stuff. > > Do you have any suggestion? Thanks! How about just calling it 'Backend' instead of 'Legacy' then ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|