From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjkuK-0006qC-WB for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjkuG-0002eg-83 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjkuF-0002eR-O6 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:36 -0400 Date: Tue, 13 Sep 2016 11:25:31 +0100 From: "Daniel P. Berrange" Message-ID: <20160913102531.GP30949@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473088600-17930-1-git-send-email-berrange@redhat.com> <1473088600-17930-5-git-send-email-berrange@redhat.com> <87bmztozsb.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87bmztozsb.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v11 4/6] qapi: rename QmpOutputVisitor to QObjectOutputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Max Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= On Mon, Sep 12, 2016 at 06:20:36PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The QmpOutputVisitor has no direct dependancy on QMP. It is > > valid to use it anywhere that one wants a QObject. Rename it > > to better reflect its functionality as a generic QAPI > > to QObject convertor. > > > > Signed-off-by: Daniel P. Berrange > > --- > > block/qapi.c | 4 +- > > blockdev.c | 4 +- > > docs/qapi-code-gen.txt | 2 +- > > ...p-output-visitor.h => qobject-output-visitor.h} | 10 +- > > qapi/Makefile.objs | 2 +- > > qapi/qapi-clone-visitor.c | 2 +- > > qapi/qmp-output-visitor.c | 256 --------------------- > > qapi/qobject-output-visitor.c | 254 ++++++++++++++++++++ > > qemu-img.c | 8 +- > > qom/object_interfaces.c | 2 +- > > qom/qom-qobject.c | 4 +- > > scripts/qapi-commands.py | 4 +- > > scripts/qapi-event.py | 4 +- > > tests/.gitignore | 2 +- > > tests/Makefile.include | 8 +- > > tests/check-qnull.c | 4 +- > > ...put-visitor.c => test-qobject-output-visitor.c} | 4 +- > > tests/test-string-output-visitor.c | 2 +- > > tests/test-visitor-serialization.c | 4 +- > > util/qemu-sockets.c | 2 +- > > 20 files changed, 290 insertions(+), 292 deletions(-) > > rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} (66%) > > delete mode 100644 qapi/qmp-output-visitor.c > > create mode 100644 qapi/qobject-output-visitor.c > > rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} (99%) > > $ git-grep -Ei 'qmp.?output.*?vis' > tests/test-qobject-output-visitor.c: * QMP Output Visitor unit-tests. Yep, will fix that. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|