Re: [PATCH v2] staging: dgnc: dgnc_cls.c: usleep_range is preferred over udelay

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Sep 13, 2016 at 01:28:39PM +0530, Anchal Jain wrote:
> According to Documentation/timers/timers-howto.txt"
> udelay() is only called once from a place where sleeping is allowed.
> We can replace it with a call to usleep_range()
> with a reasonable upper limit
> 
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> 
> Change in v2:
> 	-By mistake another patch was mixed so, Remove that patch file
>  drivers/staging/dgnc/dgnc_cls.c      |  6 +++---
>  drivers/staging/wilc1000/linux_mon.c | 11 +++++++++++
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 4e1e0dc6..1b07255 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -410,7 +410,7 @@ static void cls_assert_modem_signals(struct channel_t *ch)
>  	writeb(out, &ch->ch_cls_uart->mcr);
>  
>  	/* Give time for the UART to actually drop the signals */
> -	udelay(10);
> +	usleep_range(10, 20);
>  }
>  
>  static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)

As others pointed out, this isn't ok to change, sorry.

greg k-h