From: Ralf Baechle <ralf@linux-mips.org>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port
Date: Tue, 13 Sep 2016 18:02:52 +0200 [thread overview]
Message-ID: <20160913160251.GC20655@linux-mips.org> (raw)
In-Reply-To: <1473092320-30019-1-git-send-email-matt.redfearn@imgtec.com>
On Mon, Sep 05, 2016 at 05:18:40PM +0100, Matt Redfearn wrote:
> If the rb532 machine is compiled without CONFIG_SERIAL_8250, the
> following linker error occurs
>
> arch/mips/built-in.o: In function `setup_serial_port':
> (.init.text+0x20c): undefined reference to `early_serial_setup'
>
> Fix this by wrapping registration of the rb532 uart in an ifdef
> CONFIG_SERIAL_8250.
This will still fail if CONFIG_SERIAL_8250 = m.
RB532 should be rewritten to use earl console rather than early_serial_setup
similar to https://git.linux-mips.org/cgit/ralf/linux.git/commit/?id=194d315da86af504559a8a21026360097575bd55
for example.
Ralf
prev parent reply other threads:[~2016-09-13 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 16:18 [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port Matt Redfearn
2016-09-05 16:18 ` Matt Redfearn
2016-09-13 16:02 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913160251.GC20655@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.