From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Ignore OpRegion panel type except on select machines Date: Wed, 14 Sep 2016 10:45:15 +0300 Message-ID: <20160914074515.GL4329@intel.com> References: <1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com> <87k2egta2b.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 011676E03C for ; Wed, 14 Sep 2016 07:45:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87k2egta2b.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Andrea Arcangeli , Rob Kramer , Alexey Shumitsky , Martin van Es , Dave Airlie , intel-gfx@lists.freedesktop.org, Trudy Tective , stable@vger.kernel.org, Marco =?iso-8859-1?Q?Kr=FCger?= , Sean Greenslade , Emil Andersen Lauridsen , Alexander Kobel , oceans112@gmail.com, James Bottomley , Robin =?iso-8859-1?Q?M=FCller?= , James Hogan List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTMsIDIwMTYgYXQgMTI6Mzc6MTZQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxMyBTZXAgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4KPiA+IFR1cm5zIG91dAo+ID4gY29tbWl0IGEwNTYyODE5NWEwZCAoImRybS9p OTE1OiBHZXQgcGFuZWxfdHlwZSBmcm9tIE9wUmVnaW9uIHBhbmVsCj4gPiBkZXRhaWxzIikgaGFz IHJlZ3Jlc3NlZCBxdWl0ZSBhIGZldyBtYWNoaW5lcy4gU28gaXQgbG9va3MgbGlrZSB3ZQo+ID4g Y2FuJ3QgdXNlIHRoZSBwYW5lbCB0eXBlIGZyb20gT3BSZWdpb24gb24gYWxsIHN5c3RlbXMsIGFu ZCB5ZXQgd2UKPiA+IGFic29sdXRlbHkgbXVzdCB1c2UgaXQgb24gc29tZSBzcGVjaWZpYyBzeXN0 ZW1zLgo+ID4KPiA+IERlc3BpdGUgdHJ5aW5nLCBJIHdhcyB1bmFibGUgdG8gZmluZCBhbnkgYXV0 b21hZ2ljIHdheSB0byBkZXRlcm1pbmUKPiA+IGlmIHRoZSBPcFJlZ2lvbiBwYW5lbCB0eXBlIGlz IHJlc3BlY3RhYmxlIG9yIG5vdC4gVGhlIG9ubHkgZ2xpbW1lcgo+ID4gb2YgaG9wZSBJIGhhZCB3 YXMgYml0IDggaW4gdGhlIFNDSUMgcmVzcG9uc2UsIGJ1dCB0aGF0IHR1cm5lZCBvdXQgdG8KPiA+ IG5vdCB3b3JrIGVpdGhlciAoaXQgd2FzIGFsd2F5cyAwIG9uIGJvdGggdHlwZXMgb2Ygc3lzdGVt cykuCj4gPgo+ID4gU28sIHRvIGZpeCB0aGUgcmVncmVzc2lvbnMgd2l0aG91dCBicmVha2luZyB0 aGUgbWFjaGluZSB3ZSBrbm93IHRvIG5lZWQKPiA+IHRoZSBPcFJlZ2lvbiBwYW5lbCB0eXBlLCBs ZXQncyBqdXN0IGFkZCBhIHF1aXJrIGZvciB0aGlzLiBPbmx5IHNwZWNpZmljCj4gPiBtYWNoaW5l cyBrbm93biB0byByZXF1aXJlIHRoZSBPcFJlZ2lvbiBwYW5lbCB0eXBlIHdpbGwgdGhlcmVmb3Jl IHVzZQo+ID4gaXQuIEV2ZXJ5b25lIGVsc2Ugd2lsbCBmYWxsIGJjayB0byB0aGUgVkJUIHBhbmVs IHR5cGUuCj4gPgo+ID4gVGhlIG9ubHkga25vd24gbWFjaGluZSBzbyBmYXIgaXMgYSAiQ29ucmFj IEdtYkggSVg0NUdNMiIuIFRoZSBQQ0kKPiA+IHN1YnN5c3RlbSBJRCBvbiB0aGlzIG1hY2hpbmUg aXMganVzdCBhIGdlbmVyaWMgODA4NjoyYTQyLCBzbyBvZiBubyB1c2UuCj4gPiBJbnN0ZWFkIHdl J2xsIGdvIHdpdGggYSBETUkgbWF0Y2guCj4gPgo+ID4gSSBzdXNwZWN0IHdlIGNhbiBub3cgYWxz byByZXZlcnQKPiA+IGNvbW1pdCBhZWRkZGEwNmMxYTcgKCJkcm0vaTkxNTogSWdub3JlIHBhbmVs IHR5cGUgZnJvbSBPcFJlZ2lvbiBvbiBTS0wiKQo+ID4gYnV0IGxldCdzIGxlYXZlIHRoYXQgdG8g YSBzZXBhcmF0ZSBwYXRjaC4KPiA+Cj4gPiB2MjogRG8gdGhlIERNSSBtYXRjaCBpbiB0aGUgb3By ZWdpb24gY29kZSBkaXJlY3RseSwgYXMgZGV2X3ByaXYtPnF1aXJrcwo+ID4gICAgIGdldHMgcG9w dWxhdGVkIHRvbyBsYXRlCj4gPgo+ID4gQ2M6IFJvYiBLcmFtZXIgPHJvYkBzb2x1dGlvbi1zcGFj ZS5jb20+Cj4gPiBDYzogTWFydGluIHZhbiBFcyA8bWFydGluQG1ydmFuZXMuY29tPgo+ID4gQ2M6 IEFuZHJlYSBBcmNhbmdlbGkgPGFhcmNhbmdlQHJlZGhhdC5jb20+Cj4gPiBDYzogRGF2ZSBBaXJs aWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiBDYzogTWFyY28gS3LDvGdlciA8a3Jnc2NoQGdtYWls LmNvbT4KPiA+IENjOiBTZWFuIEdyZWVuc2xhZGUgPHNlYW5Ac2VhbmdyZWVuc2xhZGUuY29tPgo+ ID4gQ2M6IFRydWR5IFRlY3RpdmUgPGJlcnRzbGFueUBnbWFpbC5jb20+Cj4gPiBDYzogUm9iaW4g TcO8bGxlciA8cm0xOTkwQGdteC5kZT4KPiA+IENjOiBBbGV4YW5kZXIgS29iZWwgPGEta29iZWxA YS1rb2JlbC5kZT4KPiA+IENjOiBBbGV4ZXkgU2h1bWl0c2t5IDxhbGV4ZXkuc2h1bWl0c2t5QGdt YWlsLmNvbT4KPiA+IENjOiBFbWlsIEFuZGVyc2VuIExhdXJpZHNlbiA8bWluZTgwOUBnbWFpbC5j b20+Cj4gPiBDYzogb2NlYW5zMTEyQGdtYWlsLmNvbQo+ID4gQ2M6IEphbWVzIEhvZ2FuIDxqYW1l c0BhbGJhbmFydHMuY29tPgo+ID4gQ2M6IEphbWVzIEJvdHRvbWxleSA8SmFtZXMuQm90dG9tbGV5 QEhhbnNlblBhcnRuZXJzaGlwLmNvbT4KPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4g PiBSZWZlcmVuY2VzOiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRl bC1nZngvMjAxNi1BdWd1c3QvMTA1NTQ1Lmh0bWwKPiA+IFJlZmVyZW5jZXM6IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LUF1Z3VzdC8xMTY4ODgu aHRtbAo+ID4gUmVmZXJlbmNlczogaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2 ZXMvaW50ZWwtZ2Z4LzIwMTYtSnVuZS8wOTg4MjYuaHRtbAo+IAo+IFJlZmVyZW5jZXM6IGh0dHA6 Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzE0NzM2MDIyMzktMTU4NTUt MS1naXQtc2VuZC1lbWFpbC1hZHJpZW52ZXJnZUBnbWFpbC5jb20KPiAKPiBBY2tlZC1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAKPiA+IEJ1Z3ppbGxhOiBodHRwczov L2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05NDgyNQo+ID4gQnVnemlsbGE6 IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MDYwCj4gPiBC dWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0 NDMKPiA+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNn aT9pZD05NzM2Mwo+ID4gRml4ZXM6IGEwNTYyODE5NWEwZCAoImRybS9pOTE1OiBHZXQgcGFuZWxf dHlwZSBmcm9tIE9wUmVnaW9uIHBhbmVsIGRldGFpbHMiKQo+ID4gVGVzdGVkLWJ5OiBNYXJjbyBL csO8Z2VyIDxrcmdzY2hAZ21haWwuY29tPgo+ID4gVGVzdGVkLWJ5OiBBbGV4ZXkgU2h1bWl0c2t5 IDxhbGV4ZXkuc2h1bWl0c2t5QGdtYWlsLmNvbT4KPiA+IFRlc3RlZC1ieTogU2VhbiBHcmVlbnNs YWRlIDxzZWFuQHNlYW5ncmVlbnNsYWRlLmNvbT4KPiA+IFRlc3RlZC1ieTogRW1pbCBBbmRlcnNl biBMYXVyaWRzZW4gPG1pbmU4MDlAZ21haWwuY29tPgo+ID4gVGVzdGVkLWJ5OiBSb2JpbiBNw7xs bGVyIDxybTE5OTBAZ214LmRlPgo+ID4gVGVzdGVkLWJ5OiBvY2VhbnMxMTJAZ21haWwuY29tCj4g PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgoKU2xhcHBlZCBvbiBhbm90aGVyIHRlc3RlZC1ieSBhbmQgcHVzaGVkIHRvIGRpbnEu IFRoYW5rcyBmb3IgdGhlIGJyb2FkCnRlc3RpbmcsIGV2ZXJ5b25lLgoKPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMgfCAyNyArKysrKysrKysrKysrKysr KysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKQo+ID4KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lvbi5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYwo+ID4gaW5kZXggYWRjYTI2MmQ1OTFh Li43YWNiYmJmOTc4MzMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9vcHJlZ2lvbi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lv bi5jCj4gPiBAQCAtMTA0Nyw2ICsxMDQ3LDIzIEBAIGVycl9vdXQ6Cj4gPiAgCXJldHVybiBlcnI7 Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaW50ZWxfdXNlX29wcmVnaW9uX3BhbmVsX3R5 cGVfY2FsbGJhY2soY29uc3Qgc3RydWN0IGRtaV9zeXN0ZW1faWQgKmlkKQo+ID4gK3sKPiA+ICsJ RFJNX0lORk8oIlVzaW5nIHBhbmVsIHR5cGUgZnJvbSBPcFJlZ2lvbiBvbiAlc1xuIiwgaWQtPmlk ZW50KTsKPiA+ICsJcmV0dXJuIDE7Cj4gPiArfQo+ID4gKwo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgZG1pX3N5c3RlbV9pZCBpbnRlbF91c2Vfb3ByZWdpb25fcGFuZWxfdHlwZVtdID0gewo+ID4g Kwl7Cj4gPiArCQkuY2FsbGJhY2sgPSBpbnRlbF91c2Vfb3ByZWdpb25fcGFuZWxfdHlwZV9jYWxs YmFjaywKPiA+ICsJCS5pZGVudCA9ICJDb25yYWMgR21iSCBJWDQ1R00yIiwKPiA+ICsJCS5tYXRj aGVzID0ge0RNSV9NQVRDSChETUlfU1lTX1ZFTkRPUiwgIkNvbnJhYyBHbWJIIiksCj4gPiArCQkJ ICAgIERNSV9NQVRDSChETUlfUFJPRFVDVF9OQU1FLCAiSVg0NUdNMiIpLAo+ID4gKwkJfSwKPiA+ ICsJfSwKPiA+ICsJeyB9Cj4gPiArfTsKPiA+ICsKPiA+ICBpbnQKPiA+ICBpbnRlbF9vcHJlZ2lv bl9nZXRfcGFuZWxfdHlwZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAg ewo+ID4gQEAgLTEwNzMsNiArMTA5MCwxNiBAQCBpbnRlbF9vcHJlZ2lvbl9nZXRfcGFuZWxfdHlw ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCX0KPiA+ICAKPiA+ICAJ LyoKPiA+ICsJICogU28gZmFyIHdlIGtub3cgdGhhdCBzb21lIG1hY2hpbmVkIG11c3QgdXNlIGl0 LCBvdGhlcnMgbXVzdCBub3QgdXNlIGl0Lgo+ID4gKwkgKiBUaGVyZSBkb2Vzbid0IHNlZW0gdG8g YmUgYW55IHdheSB0byBkZXRlcm1pbmUgd2hpY2ggd2F5IHRvIGdvLCBleGNlcHQKPiA+ICsJICog dmlhIGEgcXVpcmsgbGlzdCA6KAo+ID4gKwkgKi8KPiA+ICsJaWYgKCFkbWlfY2hlY2tfc3lzdGVt KGludGVsX3VzZV9vcHJlZ2lvbl9wYW5lbF90eXBlKSkgewo+ID4gKwkJRFJNX0RFQlVHX0tNUygi SWdub3JpbmcgT3BSZWdpb24gcGFuZWwgdHlwZSAoJWQpXG4iLCByZXQgLSAxKTsKPiA+ICsJCXJl dHVybiAtRU5PREVWOwo+ID4gKwl9Cj4gPiArCj4gPiArCS8qCj4gPiAgCSAqIEZJWE1FIE9uIERl bGwgWFBTIDEzIDkzNTAgdGhlIE9wUmVnaW9uIHBhbmVsIHR5cGUgKDApIGdpdmVzIHVzCj4gPiAg CSAqIGxvdyB2c3dpbmcgZm9yIGVEUCwgd2hlcmVhcyB0aGUgVkJUIHBhbmVsIHR5cGUgKDIpIGdp dmVzIHVzIG5vcm1hbAo+ID4gIAkgKiB2c3dpbmcgaW5zdGVhZC4gTG93IHZzd2luZyByZXN1bHRz IGluIHNvbWUgZGlzcGxheSBmbGlja2Vycywgc28KPiAKPiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:32102 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761832AbcINHpc (ORCPT ); Wed, 14 Sep 2016 03:45:32 -0400 Date: Wed, 14 Sep 2016 10:45:15 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Andrea Arcangeli , Sean Greenslade , Alexey Shumitsky , Martin van Es , Dave Airlie , James Hogan , stable@vger.kernel.org, Marco =?iso-8859-1?Q?Kr=FCger?= , Rob Kramer , Emil Andersen Lauridsen , Alexander Kobel , oceans112@gmail.com, James Bottomley , Robin =?iso-8859-1?Q?M=FCller?= , Trudy Tective Subject: Re: [Intel-gfx] [PATCH] drm/i915: Ignore OpRegion panel type except on select machines Message-ID: <20160914074515.GL4329@intel.com> References: <1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com> <87k2egta2b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k2egta2b.fsf@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Sep 13, 2016 at 12:37:16PM +0300, Jani Nikula wrote: > On Tue, 13 Sep 2016, ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj�l� > > > > Turns out > > commit a05628195a0d ("drm/i915: Get panel_type from OpRegion panel > > details") has regressed quite a few machines. So it looks like we > > can't use the panel type from OpRegion on all systems, and yet we > > absolutely must use it on some specific systems. > > > > Despite trying, I was unable to find any automagic way to determine > > if the OpRegion panel type is respectable or not. The only glimmer > > of hope I had was bit 8 in the SCIC response, but that turned out to > > not work either (it was always 0 on both types of systems). > > > > So, to fix the regressions without breaking the machine we know to need > > the OpRegion panel type, let's just add a quirk for this. Only specific > > machines known to require the OpRegion panel type will therefore use > > it. Everyone else will fall bck to the VBT panel type. > > > > The only known machine so far is a "Conrac GmbH IX45GM2". The PCI > > subsystem ID on this machine is just a generic 8086:2a42, so of no use. > > Instead we'll go with a DMI match. > > > > I suspect we can now also revert > > commit aeddda06c1a7 ("drm/i915: Ignore panel type from OpRegion on SKL") > > but let's leave that to a separate patch. > > > > v2: Do the DMI match in the opregion code directly, as dev_priv->quirks > > gets populated too late > > > > Cc: Rob Kramer > > Cc: Martin van Es > > Cc: Andrea Arcangeli > > Cc: Dave Airlie > > Cc: Marco Kr�ger > > Cc: Sean Greenslade > > Cc: Trudy Tective > > Cc: Robin M�ller > > Cc: Alexander Kobel > > Cc: Alexey Shumitsky > > Cc: Emil Andersen Lauridsen > > Cc: oceans112@gmail.com > > Cc: James Hogan > > Cc: James Bottomley > > Cc: stable@vger.kernel.org > > References: https://lists.freedesktop.org/archives/intel-gfx/2016-August/105545.html > > References: https://lists.freedesktop.org/archives/dri-devel/2016-August/116888.html > > References: https://lists.freedesktop.org/archives/intel-gfx/2016-June/098826.html > > References: http://patchwork.freedesktop.org/patch/msgid/1473602239-15855-1-git-send-email-adrienverge@gmail.com > > Acked-by: Jani Nikula > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94825 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97060 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97443 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97363 > > Fixes: a05628195a0d ("drm/i915: Get panel_type from OpRegion panel details") > > Tested-by: Marco Kr�ger > > Tested-by: Alexey Shumitsky > > Tested-by: Sean Greenslade > > Tested-by: Emil Andersen Lauridsen > > Tested-by: Robin M�ller > > Tested-by: oceans112@gmail.com > > Signed-off-by: Ville Syrj�l� Slapped on another tested-by and pushed to dinq. Thanks for the broad testing, everyone. > > --- > > drivers/gpu/drm/i915/intel_opregion.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > > index adca262d591a..7acbbbf97833 100644 > > --- a/drivers/gpu/drm/i915/intel_opregion.c > > +++ b/drivers/gpu/drm/i915/intel_opregion.c > > @@ -1047,6 +1047,23 @@ err_out: > > return err; > > } > > > > +static int intel_use_opregion_panel_type_callback(const struct dmi_system_id *id) > > +{ > > + DRM_INFO("Using panel type from OpRegion on %s\n", id->ident); > > + return 1; > > +} > > + > > +static const struct dmi_system_id intel_use_opregion_panel_type[] = { > > + { > > + .callback = intel_use_opregion_panel_type_callback, > > + .ident = "Conrac GmbH IX45GM2", > > + .matches = {DMI_MATCH(DMI_SYS_VENDOR, "Conrac GmbH"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "IX45GM2"), > > + }, > > + }, > > + { } > > +}; > > + > > int > > intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > > { > > @@ -1073,6 +1090,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > > } > > > > /* > > + * So far we know that some machined must use it, others must not use it. > > + * There doesn't seem to be any way to determine which way to go, except > > + * via a quirk list :( > > + */ > > + if (!dmi_check_system(intel_use_opregion_panel_type)) { > > + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); > > + return -ENODEV; > > + } > > + > > + /* > > * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us > > * low vswing for eDP, whereas the VBT panel type (2) gives us normal > > * vswing instead. Low vswing results in some display flickers, so > > -- > Jani Nikula, Intel Open Source Technology Center -- Ville Syrj�l� Intel OTC