From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760897AbcINJow (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 05:44:52 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:48829 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752028AbcINJov (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 05:44:51 -0400
Date: Wed, 14 Sep 2016 11:44:56 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH] driver-core: platform: Catch errors from calls to
 irq_get_irq_data
Message-ID: <20160914094456.GA5826@kroah.com>
References: <1473823964-27402-1-git-send-email-linux@roeck-us.net>
 <CACRpkdYSr-4wbsupAPa6Q1nd6THf9YS4TMYa5OqMzF6GNOBMxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdYSr-4wbsupAPa6Q1nd6THf9YS4TMYa5OqMzF6GNOBMxg@mail.gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2016 at 11:06:08AM +0200, Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > irq_get_irq_data() can return NULL, which results in a nasty crash.
> > Check its return value before passing it on to irqd_set_trigger_type().
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Should probably be tagged for stable.

Why, are there any systems that are currently broken without this change
right now?

thanks,

greg k-h