From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Vasily Philipov <vasilyf@mellanox.com>
Subject: Re: [PATCH 8/8] net/mlx5: fix inline logic
Date: Wed, 14 Sep 2016 13:07:31 +0200 [thread overview]
Message-ID: <20160914110730.GF32397@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <b65901bb-9ae8-bdb1-4634-c7a0f63fcce0@intel.com>
On Wed, Sep 14, 2016 at 11:43:35AM +0100, Ferruh Yigit wrote:
> Hi Nelio,
>
> On 9/7/2016 8:02 AM, Nelio Laranjeiro wrote:
> > To improve performance the NIC expects for large packets to have a pointer
> > to a cache aligned address, old inline code could break this assumption
> > which hurts performance.
> >
> > Fixes: 2a66cf378954 ("net/mlx5: support inline send")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Signed-off-by: Vasily Philipov <vasilyf@mellanox.com>
> > ---
>
> ...
>
> > @@ -607,8 +523,13 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
> > MLX5_ETH_WQE_L3_CSUM |
> > MLX5_ETH_WQE_L4_CSUM;
> > } else {
> > - wqe->wqe.eseg.cs_flags = 0;
> > + wqe->eseg.cs_flags = 0;
>
> This cause a compilation error, and looks like a typo:
>
> .../drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_burst’:
> .../drivers/net/mlx5/mlx5_rxtx.c:526:7: error: ‘volatile union mlx5_wqe’
> has no member named ‘eseg’
> wqe->eseg.cs_flags = 0;
> ^~
Hi Ferruh,
You are totally right. I will fix it, re-test and send a V2 today.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2016-09-14 11:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 7:02 [PATCH 0/8] net/mlx5: various fixes Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 1/8] net/mlx5: fix inconsistent return value in Flow Director Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 2/8] net/mlx5: fix Rx VLAN offload capability report Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 3/8] net/mlx5: fix removing VLAN filter Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 4/8] net/mlx5: refactor allocation of flow director queues Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 5/8] net/mlx5: fix support for flow director drop mode Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 6/8] net/mlx5: force inline for completion function Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 7/8] net/mlx5: re-factorize functions Nelio Laranjeiro
2016-09-07 7:02 ` [PATCH 8/8] net/mlx5: fix inline logic Nelio Laranjeiro
2016-09-14 10:43 ` Ferruh Yigit
2016-09-14 11:07 ` Nélio Laranjeiro [this message]
2016-09-14 11:53 ` [PATCH V2 0/8] net/mlx5: various fixes Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 1/8] net/mlx5: fix inconsistent return value in Flow Director Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 2/8] net/mlx5: fix Rx VLAN offload capability report Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 3/8] net/mlx5: fix removing VLAN filter Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 4/8] net/mlx5: refactor allocation of flow director queues Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 5/8] net/mlx5: fix support for flow director drop mode Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 6/8] net/mlx5: force inline for completion function Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 7/8] net/mlx5: re-factorize functions Nelio Laranjeiro
2016-09-14 11:53 ` [PATCH V2 8/8] net/mlx5: fix inline logic Nelio Laranjeiro
2016-09-14 12:21 ` [PATCH V2 0/8] net/mlx5: various fixes Nélio Laranjeiro
2016-09-19 15:30 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914110730.GF32397@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=vasilyf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.