Re: [PATCH V1] xen/arm: domain_build: introduce dom0_lowmem bootargs

[Peng Fan <van.freenix@gmail.com>]

Hello Julien,
On Wed, Sep 14, 2016 at 11:47:10AM +0100, Julien Grall wrote:
>Hello,
>
>On 14/09/16 08:41, Peng Fan wrote:
>>On Wed, Sep 14, 2016 at 08:23:24AM +0100, Julien Grall wrote:
>>diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>>index 35ab08d..cc71e6f 100644
>>--- a/xen/arch/arm/domain_build.c
>>+++ b/xen/arch/arm/domain_build.c
>>@@ -28,6 +28,8 @@
>>
>>static unsigned int __initdata opt_dom0_max_vcpus;
>>integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>>+static bool_t __initdata opt_dom0_use_lowmem;
>>+boolean_param("dom0_use_lowmem", opt_dom0_use_lowmem);
>>
>>int dom0_11_mapping = 1;
>>
>>@@ -244,7 +246,7 @@ static void allocate_memory(struct domain *d, struct
>>kernel_info *kinfo)
>>     unsigned int order = get_11_allocation_size(kinfo->unassigned_mem);
>>     int i;
>>	
>>-    bool_t lowmem = is_32bit_domain(d);
>>+    bool_t lowmem = is_32bit_domain(d) || opt_dom0_use_lowmem;
>>     unsigned int bits;
>>
>>
>>Pass "dom0_use_lowmem=1" to xen to allocate lowmem as much as possible.
>
>Again, what is the benefit to have a command line option for that?

Then you prefer directly change "bool_t lowmem = is_32bit_domain(d);" to "bool_t lowmem = true" ?
I just want to give user a choice.

Thanks,
Peng.

>
>Regards,
>
>-- 
>Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel