From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] dma-buf/sync_file: Always increment refcount when merging fences. Date: Wed, 14 Sep 2016 11:04:01 -0300 Message-ID: <20160914140401.GA3076@joana> References: <1473809067-6019-1-git-send-email-rafael.antognolli@intel.com> <20160914100519.GI25204@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id A38916E72F for ; Wed, 14 Sep 2016 14:04:16 +0000 (UTC) Received: by mail-yw0-f195.google.com with SMTP id t67so868579ywg.1 for ; Wed, 14 Sep 2016 07:04:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160914100519.GI25204@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Rafael Antognolli , dri-devel@lists.freedesktop.org, gustavo.padovan@collabora.co.uk List-Id: dri-devel@lists.freedesktop.org MjAxNi0wOS0xNCBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az46Cgo+IE9u IFR1ZSwgU2VwIDEzLCAyMDE2IGF0IDA0OjI0OjI3UE0gLTA3MDAsIFJhZmFlbCBBbnRvZ25vbGxp IHdyb3RlOgo+ID4gVGhlIHJlZmNvdW50IG9mIGEgZmVuY2Ugc2hvdWxkIGJlIGluY3JlYXNlZCB3 aGVuZXZlciBpdCBpcyBhZGRlZCB0byBhIG1lcmdlZAo+ID4gZmVuY2UsIHNpbmNlIGl0IHdpbGwg bGF0ZXIgYmUgZGVjcmVhc2VkIHdoZW4gdGhlIG1lcmdlZCBmZW5jZSBpcyBkZXN0cm95ZWQuCj4g PiBGYWlsaW5nIHRvIGRvIHNvIHdpbGwgY2F1c2UgdGhlIG9yaWdpbmFsIGZlbmNlIHRvIGJlIGZy ZWVkIGlmIHRoZSBtZXJnZWQgZmVuY2UKPiA+IGdldHMgZnJlZWQsIGJ1dCBvdGhlciBwbGFjZXMg c3RpbGwgcmVmZXJlbmNpbmcgd29uJ3Qga25vdyBhYm91dCBpdC4KPiA+IAo+ID4gVGhpcyBwYXRj aCBmaXhlcyBhIGtlcm5lbCBwYW5pYyB0aGF0IGNhbiBiZSB0cmlnZ2VyZWQgYnkgY3JlYXRpbmcg YSBmZW5jZSB0aGF0Cj4gPiBpcyBleHBpcmVkIChvciBpbmNyZWFzaW5nIHRoZSB0aW1lbGluZSB1 bnRpbCBpdCBleHBpcmVzKSwgdGhlbiBjcmVhdGluZyBhCj4gPiBtZXJnZWQgZmVuY2Ugb3V0IG9m IGl0LCBhbmQgZGVsZXRpbmcgdGhlIG1lcmdlZCBmZW5jZS4gVGhpcyB3aWxsIG1ha2UgdGhlCj4g PiBvcmlnaW5hbCBleHBpcmVkIGZlbmNlJ3MgcmVmY291bnQgZ28gdG8gemVyby4KPiA+IAo+ID4g U2lnbmVkLW9mZi1ieTogUmFmYWVsIEFudG9nbm9sbGkgPHJhZmFlbC5hbnRvZ25vbGxpQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gCj4gPiBTYW1wbGUgY29kZSB0byB0cmlnZ2VyIHRoZSBtZW50aW9u ZWQga2VybmVsIHBhbmljIChtaWdodCBuZWVkIHRvIGJlIGV4ZWN1dGVkIGEKPiA+IGNvdXBsZSB0 aW1lcyBiZWZvcmUgaXQgYWN0dWFsbHkgYnJlYWtzIGV2ZXJ5dGhpbmcpOgo+ID4gCj4gPiBzdGF0 aWMgdm9pZCB0ZXN0X3N5bmNfZXhwaXJlZF9tZXJnZSh2b2lkKQo+ID4gewo+ID4gICAgICAgIGlu dCBpdGVyYXRpb25zID0gMSA8PCAyMDsKPiA+ICAgICAgICBpbnQgdGltZWxpbmU7Cj4gPiAgICAg ICAgaW50IGk7Cj4gPiAgICAgICAgaW50IGZlbmNlX2V4cGlyZWQsIGZlbmNlX21lcmdlZDsKPiA+ IAo+ID4gICAgICAgIHRpbWVsaW5lID0gc3dfc3luY190aW1lbGluZV9jcmVhdGUoKTsKPiA+IAo+ ID4gICAgICAgIHN3X3N5bmNfdGltZWxpbmVfaW5jKHRpbWVsaW5lLCAxMDApOwo+ID4gICAgICAg IGZlbmNlX2V4cGlyZWQgPSBzd19zeW5jX2ZlbmNlX2NyZWF0ZSh0aW1lbGluZSwgMSk7Cj4gPiAg ICAgICAgZmVuY2VfbWVyZ2VkID0gc3dfc3luY19tZXJnZShmZW5jZV9leHBpcmVkLCBmZW5jZV9l eHBpcmVkKTsKPiA+ICAgICAgICBzd19zeW5jX2ZlbmNlX2Rlc3Ryb3koZmVuY2VfbWVyZ2VkKTsK PiA+IAo+ID4gICAgICAgIGZvciAoaSA9IDA7IGkgPCBpdGVyYXRpb25zOyBpKyspIHsKPiA+ICAg ICAgICAgICAgICAgIGludCBmZW5jZSA9IHN3X3N5bmNfbWVyZ2UoZmVuY2VfZXhwaXJlZCwgZmVu Y2VfZXhwaXJlZCk7Cj4gPiAKPiA+ICAgICAgICAgICAgICAgIGlndF9hc3NlcnRfZihzd19zeW5j X3dhaXQoZmVuY2UsIC0xKSA+IDAsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiRmFpbHVyZSB3YWl0aW5nIG9uIGZlbmNlXG4iKTsKPiA+ICAgICAgICAgICAgICAgIHN3 X3N5bmNfZmVuY2VfZGVzdHJveShmZW5jZSk7Cj4gPiAgICAgICAgfQo+ID4gCj4gPiAgICAgICAg c3dfc3luY19mZW5jZV9kZXN0cm95KGZlbmNlX2V4cGlyZWQpOwo+ID4gfQo+ID4gCj4gPiAgZHJp dmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jIHwgNyArKy0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+ ID4gaW5kZXggNDg2ZDI5Yy4uNmNlNmI4ZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1 Zi9zeW5jX2ZpbGUuYwo+ID4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jCj4gPiBA QCAtMTc4LDExICsxNzgsOCBAQCBzdGF0aWMgc3RydWN0IGZlbmNlICoqZ2V0X2ZlbmNlcyhzdHJ1 Y3Qgc3luY19maWxlICpzeW5jX2ZpbGUsIGludCAqbnVtX2ZlbmNlcykKPiA+ICBzdGF0aWMgdm9p ZCBhZGRfZmVuY2Uoc3RydWN0IGZlbmNlICoqZmVuY2VzLCBpbnQgKmksIHN0cnVjdCBmZW5jZSAq ZmVuY2UpCj4gPiAgewo+ID4gIAlmZW5jZXNbKmldID0gZmVuY2U7Cj4gPiAtCj4gPiAtCWlmICgh ZmVuY2VfaXNfc2lnbmFsZWQoZmVuY2UpKSB7Cj4gPiAtCQlmZW5jZV9nZXQoZmVuY2UpOwo+ID4g LQkJKCppKSsrOwo+ID4gLQl9Cj4gPiArCWZlbmNlX2dldChmZW5jZSk7Cj4gPiArCSgqaSkrKzsK PiA+ICB9Cj4gCj4gSSB0aGluayB5b3UnbGwgZmluZCBpdCdzIHRoZSBjYWxsZXI6Cj4gCj4gaWYg KGkgPT0gMCkgewo+IAlhZGRfZmVuY2UoZmVuY2VzLCAmaSwgYV9mZW5jZXNbMF0pOwo+IAlpKys7 Cj4gfQo+IAo+IHRoYXQgZG9lcyB0aGUgdW5leHBlY3RlZC4KPiAKPiBUaGlzIHNob3VsZCBiZSAK PiAKPiBpZiAoaSA9PSAwKQo+IAlmZW5jZXNbaSsrXSA9IGZlbmNlX2dldChhX2ZlbmNlc1swXSk7 CgpZb3UgYXJlIHJpZ2h0LiBPdGhlcndpc2Ugd2Ugd291bGQgbWlzcyB0aGUgZXh0cmEgcmVmZXJl bmNlLiBpID09IDAgaGVyZQptZWFucyB0aGF0IGFsbCBmZW5jZXMgYXJlIHNpZ25hbGxlZC4KCj4g Cj4gCj4gVGhhdCBlbnN1cmVzIHRoZSBzeW5jX2ZpbGUgaW5oZXJpdHMgdGhlIHNpZ25hbGVkIHN0 YXR1cyB3aXRob3V0IGhhdmluZwo+IHRvIGtlZXAgYWxsIGZlbmNlcy4KPiAKPiBJIHRoaW5rIHRo ZXJlIHN0aWxsIHNlZW1zIHRvIGJlIGEgbWVtb3J5IGxlYWsgd2hlbiBjYWxsaW5nCj4gc3luY19m aWxlX3NldF9mZW5jZSgpIGhlcmUgd2l0aCBpID09IDEuCgpJIHRoaW5rIHRoYXQgaXMgc29tZXRo aW5nIHdlIGRpc2N1c3NlZCBhbHJlYWR5LCB3ZSBkb24ndCBob2xkIGFuIGV4dHJhCnJlZiB0aGVy ZSBmb3IgaSA9PSAxIGJlY2F1c2UgaXQgd291bGQgbGVhayB0aGUgZmVuY2UuCgpHdXN0YXZvCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK