From: Bjorn Helgaas <helgaas@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mayurkumar Patel <mayurkumar.patel@intel.com>,
Rajat Jain <rajatja@google.com>,
MikaWesterberg@linux.intel.com, linux-pci@vger.kernel.org,
Rafael J Wysocki <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
Luis Antonio Tarazona-Duarte
<luis.antonio.tarazona-duarte@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine
Date: Wed, 14 Sep 2016 14:26:21 -0500 [thread overview]
Message-ID: <20160914192621.GA10559@localhost> (raw)
In-Reply-To: <20160914084117.GX1811@lahna.fi.intel.com>
On Wed, Sep 14, 2016 at 11:41:17AM +0300, Mika Westerberg wrote:
> On Mon, Sep 12, 2016 at 04:08:47PM -0500, Bjorn Helgaas wrote:
> > This is mostly Mayurkumar's work from [1] and [2]. I split [2] into two
> > patches and reworked it to keep the enclosing loop around the pciehp ISR.
> >
> > The patches I added are trivial ones to clarify variable names, make dmesg
> > messages consistent, and remove useless code.
> >
> > [1] 1471554479-42083-1-git-send-email-mayurkumar.patel@intel.com
> > [2] 92EBB4272BF81E4089A7126EC1E7B28466598F35@IRSMSX101.ger.corp.intel.com
> >
> > ---
> >
> > Bjorn Helgaas (5):
> > PCI: pciehp: Rename pcie_isr() locals for clarity
> > PCI: pciehp: Return IRQ_NONE when we can't read interrupt status
> > PCI: pciehp: Remove unnecessary guard
> > PCI: pciehp: Clean up dmesg "Slot(%s)" messages
> > PCI: pciehp: Remove useless pciehp_get_latch_status() calls
> >
> > Mayurkumar Patel (3):
> > PCI: pciehp: Process all hotplug events before looking for new ones
> > PCI: pciehp: Don't re-read Slot Status when queuing hotplug event
> > PCI: pciehp: Don't re-read Slot Status when handling surprise event
> >
> >
> > drivers/pci/hotplug/pciehp_ctrl.c | 83 ++++++++++++---------------------
> > drivers/pci/hotplug/pciehp_hpc.c | 94 ++++++++++++++++++++-----------------
> > 2 files changed, 82 insertions(+), 95 deletions(-)
>
> I don't have any machines with native PCIe hotplug support enabled but
> regardless the series looks good to me,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks a lot for taking the time to review it! I added your Reviewed-by.
next prev parent reply other threads:[~2016-09-14 19:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 21:08 [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine Bjorn Helgaas
2016-09-12 21:08 ` [PATCH v2 1/8] PCI: pciehp: Rename pcie_isr() locals for clarity Bjorn Helgaas
2016-09-13 10:05 ` Patel, Mayurkumar
2016-09-13 10:05 ` Patel, Mayurkumar
2016-09-13 13:57 ` Bjorn Helgaas
2016-09-13 16:09 ` Patel, Mayurkumar
2016-09-13 16:09 ` Patel, Mayurkumar
2016-09-12 21:09 ` [PATCH v2 2/8] PCI: pciehp: Return IRQ_NONE when we can't read interrupt status Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 3/8] PCI: pciehp: Process all hotplug events before looking for new ones Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 4/8] PCI: pciehp: Don't re-read Slot Status when queuing hotplug event Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 5/8] PCI: pciehp: Don't re-read Slot Status when handling surprise event Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 6/8] PCI: pciehp: Remove unnecessary guard Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 7/8] PCI: pciehp: Clean up dmesg "Slot(%s)" messages Bjorn Helgaas
2016-09-12 21:09 ` [PATCH v2 8/8] PCI: pciehp: Remove useless pciehp_get_latch_status() calls Bjorn Helgaas
2016-09-13 16:20 ` [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine Lukas Wunner
2016-09-13 18:20 ` Bjorn Helgaas
2016-09-14 8:41 ` Mika Westerberg
2016-09-14 19:26 ` Bjorn Helgaas [this message]
2016-09-14 21:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914192621.GA10559@localhost \
--to=helgaas@kernel.org \
--cc=MikaWesterberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luis.antonio.tarazona-duarte@intel.com \
--cc=mayurkumar.patel@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.