From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkKV0-0000dX-1k for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:25:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkKUv-0004ST-6Q for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:25:53 -0400 Date: Thu, 15 Sep 2016 10:09:59 +1000 From: David Gibson Message-ID: <20160915000959.GA15077@voom.fritz.box> References: <1473878907-10477-1-git-send-email-lvivier@redhat.com> <1473878907-10477-6-git-send-email-lvivier@redhat.com> <71be7db9-c6b4-5f1a-f99e-2f4a9e8986ad@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVmWh8UkjoBIyGkN" Content-Disposition: inline In-Reply-To: <71be7db9-c6b4-5f1a-f99e-2f4a9e8986ad@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Laurent Vivier , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --EVmWh8UkjoBIyGkN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2016 at 09:56:47PM +0200, Thomas Huth wrote: > On 14.09.2016 20:48, Laurent Vivier wrote: > > Signed-off-by: Laurent Vivier > > --- > > hw/scsi/spapr_vscsi.c | 89 +++++++++++++++++++++----------------------= -------- > > hw/scsi/trace-events | 27 ++++++++++++++++ > > 2 files changed, 63 insertions(+), 53 deletions(-) > >=20 > > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > > index 8fbd50f..29fef90 100644 > > --- a/hw/scsi/spapr_vscsi.c > > +++ b/hw/scsi/spapr_vscsi.c >=20 > While you're at it: There is a stray fprintf statement at the beginning > of vscsi_process_tsk_mgmt() which is rather a debug statement than > really something that should be printed always ... could you please turn > that into a trace event, too? That would be a good idea, but I'd prefer to see it as a follow up patch. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --EVmWh8UkjoBIyGkN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX2ebWAAoJEGw4ysog2bOSqqcP/A3SfPMZ8cY0N/4OBJq0BYJ/ 1invx+nOyYIV2O0n83A2BEDS+scMqgoeB7Loq0JGVBWGn8mKATNmabjCcvIWpfpC RfiiADJIwt4znlSgLQ3G4ZSVSnKfTjUpWcZzbSoyzy9ZuBbeC14d6VT80fIIM7yg pdlKXY6tZaEO1SnjiIoJeVP5WjBCQN693AKjgGS+wnxIXy/7KPEwvRSPDq9H8ZZQ 1QyehDRKJG+QueeXQG8FKNe6kWif4oAFYvq5mC5vs13K5+NJNCz6CeXMmgq+Y9KF rvWPpugMyXASVp8dZs3VJG4ejwYmNZ45iNr/ffJxZz4qkTyYgCRMfjqafvsJloyk WIBZ21DkXAMN21JErxd69cprVs+Eavb4AX7nFvARVZZie1V8UUbnLxYHIus4ure1 +56YziIECLkl0Q3CHc9T29XHcZG+/zT5dwgFmulAHRjTX9f1EF73j36QTmfJ6IN5 JujtEvrVkBPvBuHrsn9VvsJbXs6PI60/A4I/a5En4lBirDwM87Q9edMKKbLUqkPC uokphWIWQVe8nFrDELSTCEPUv+9XjR0Gm2SHdc56MXUXvPlSXyIzanCgg6W9IiMS u6YaJ9pLTIrqW2/xgRNkNYNr+gTRZPFnPUuhOgMWCt+CxCFLEgcX+sLtt83jqiHg 20e8cVueUss/BOnImsjC =sUnq -----END PGP SIGNATURE----- --EVmWh8UkjoBIyGkN--