From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkKzH-000450-8O for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:57:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkKzD-0006fO-8N for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:57:11 -0400 Date: Thu, 15 Sep 2016 10:46:23 +1000 From: David Gibson Message-ID: <20160915004623.GF15077@voom.fritz.box> References: <1473662506-27441-1-git-send-email-nikunj@linux.vnet.ibm.com> <1473662506-27441-2-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Jch8HTrQBXCJArxs" Content-Disposition: inline In-Reply-To: <1473662506-27441-2-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RESEND v2 01/17] target-ppc: consolidate load operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, benh@kernel.crashing.org --Jch8HTrQBXCJArxs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 12, 2016 at 12:11:30PM +0530, Nikunj A Dadhania wrote: > Implement macro to consolidate store operations using newer > tcg_gen_qemu_ld functions. s/store/load/, but I can fix that as I apply if I don't find anything else in the series which requires a respin. >=20 > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/translate.c | 58 +++++++++++++++++---------------------------= ------ > 1 file changed, 20 insertions(+), 38 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index a27f455..6606969 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -2462,50 +2462,32 @@ static inline void gen_align_no_le(DisasContext *= ctx) > } > =20 > /*** Integer load = ***/ > -static inline void gen_qemu_ld8u(DisasContext *ctx, TCGv arg1, TCGv arg2) > -{ > - tcg_gen_qemu_ld8u(arg1, arg2, ctx->mem_idx); > -} > - > -static inline void gen_qemu_ld16u(DisasContext *ctx, TCGv arg1, TCGv arg= 2) > -{ > - TCGMemOp op =3D MO_UW | ctx->default_tcg_memop_mask; > - tcg_gen_qemu_ld_tl(arg1, arg2, ctx->mem_idx, op); > -} > - > -static inline void gen_qemu_ld16s(DisasContext *ctx, TCGv arg1, TCGv arg= 2) > -{ > - TCGMemOp op =3D MO_SW | ctx->default_tcg_memop_mask; > - tcg_gen_qemu_ld_tl(arg1, arg2, ctx->mem_idx, op); > -} > +#define DEF_MEMOP(op) ((op) | ctx->default_tcg_memop_mask) > =20 > -static inline void gen_qemu_ld32u(DisasContext *ctx, TCGv arg1, TCGv arg= 2) > -{ > - TCGMemOp op =3D MO_UL | ctx->default_tcg_memop_mask; > - tcg_gen_qemu_ld_tl(arg1, arg2, ctx->mem_idx, op); > +#define GEN_QEMU_LOAD_TL(ldop, op) \ > +static void glue(gen_qemu_, ldop)(DisasContext *ctx, \ > + TCGv val, \ > + TCGv addr) \ > +{ \ > + tcg_gen_qemu_ld_tl(val, addr, ctx->mem_idx, op); \ > } > =20 > -static void gen_qemu_ld32u_i64(DisasContext *ctx, TCGv_i64 val, TCGv add= r) > -{ > - TCGv tmp =3D tcg_temp_new(); > - gen_qemu_ld32u(ctx, tmp, addr); > - tcg_gen_extu_tl_i64(val, tmp); > - tcg_temp_free(tmp); > -} > +GEN_QEMU_LOAD_TL(ld8u, DEF_MEMOP(MO_UB)) > +GEN_QEMU_LOAD_TL(ld16u, DEF_MEMOP(MO_UW)) > +GEN_QEMU_LOAD_TL(ld16s, DEF_MEMOP(MO_SW)) > +GEN_QEMU_LOAD_TL(ld32u, DEF_MEMOP(MO_UL)) > +GEN_QEMU_LOAD_TL(ld32s, DEF_MEMOP(MO_SL)) > =20 > -static inline void gen_qemu_ld32s(DisasContext *ctx, TCGv arg1, TCGv arg= 2) > -{ > - TCGMemOp op =3D MO_SL | ctx->default_tcg_memop_mask; > - tcg_gen_qemu_ld_tl(arg1, arg2, ctx->mem_idx, op); > +#define GEN_QEMU_LOAD_64(ldop, op) \ > +static void glue(gen_qemu_, glue(ldop, _i64))(DisasContext *ctx, \ > + TCGv_i64 val, \ > + TCGv addr) \ > +{ \ > + tcg_gen_qemu_ld_i64(val, addr, ctx->mem_idx, op); \ > } > =20 > -static void gen_qemu_ld32s_i64(DisasContext *ctx, TCGv_i64 val, TCGv add= r) > -{ > - TCGv tmp =3D tcg_temp_new(); > - gen_qemu_ld32s(ctx, tmp, addr); > - tcg_gen_ext_tl_i64(val, tmp); > - tcg_temp_free(tmp); > -} > +GEN_QEMU_LOAD_64(ld32u, DEF_MEMOP(MO_UL)) > +GEN_QEMU_LOAD_64(ld32s, DEF_MEMOP(MO_SL)) > =20 > static inline void gen_qemu_ld64(DisasContext *ctx, TCGv_i64 arg1, TCGv = arg2) > { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Jch8HTrQBXCJArxs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX2e9fAAoJEGw4ysog2bOSrSkP/3IkZxkpZ0Mgq0v41BRjv+OI W2nJwfUFcRgsrx9k2lPW7YOLrRAzWAqGuJFesD1abBkeDkWlw55PJBoM6XA+3ONU hnW0Gbq5dxv/sR7Su/MJ9BgkJYAnsyCTwgR6OX8XMOK8kCjULZEzcJqq45H6S85x tSvfOgQ5tBZI0NOD34pESDhRSxsem86oQUhU5Uo+lrz4g0Yeih9ewFqXlCcOyVNh d4Lgrf0BD9lneIfNmW9wC3PNghxz6DHmIJcNDXFxgAFoxy3XNY/YHCBtfFPtVmJ9 Pa6NKplAcwy2WhD33b/fraC0E8ZX2TvLi1PIZ32BMOiblF/Fu9tyC4m9KAsVUJvx gN0p68CTZXuguLMAklCb68ZR1L1IdpXwkSfd+Sr/Y87r1TkjCvJ7leovggHIoSH8 GrVe/MUIltQ/w9jtYROd6PBEt5xxFzJ4oZP6hF+zjwqiQDX6BxCy5jKTfPxLGFAt Qgt3pfEmyYZcetA++QfFmATXbz2uf70rLHlI2XubkWvN4zVsa93EPVZT7PuQ0Ww/ ugGdob6dyukTg1/yT7CPWL8AlHTDVFBMlsOvxGxvZd++GrjG7xwQ4pFYm7LE4KWE iYu75GpsNe7qwe/CuI2ogob6Mld0ge+HfqGRVvhhYKLIdp71oLEM+8jFlA6kGhez aU0PR54lhryPL/S8J1Ed =c8hP -----END PGP SIGNATURE----- --Jch8HTrQBXCJArxs--