From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkUvp-0008G5-A1 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 07:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkUvl-0002ZX-MX for qemu-devel@nongnu.org; Thu, 15 Sep 2016 07:34:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkUvl-0002ZC-H0 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 07:34:13 -0400 Date: Thu, 15 Sep 2016 12:34:09 +0100 From: "Daniel P. Berrange" Message-ID: <20160915113409.GJ26068@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473088600-17930-1-git-send-email-berrange@redhat.com> <20160914150405.GG4649@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160914150405.GG4649@noname.redhat.com> Subject: Re: [Qemu-devel] [PATCH v11 0/6] QAPI/QOM work for non-scalar object properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Markus Armbruster , Max Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= On Wed, Sep 14, 2016 at 05:04:05PM +0200, Kevin Wolf wrote: > Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > > This patch series contains only the QAPI/QOM bits of my previous > > access control patch series: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html > > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html > > v4: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01661.html > > v5: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg00485.html > > v6: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg03876.html > > v7: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00919.html > > v8: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg03115.html > > v9: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02653.html > > v10: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02694.html > > > > This series provides the infrastructure to allow use of non-scalar > > properties with the -object CLI arg, and object_add monitor commands. > > eg a property which is a list of structs. The syntax used for this is > > intentionally compatible with the syntax used by the block layer. This > > will allow the qdict_crumple method to be used by the block layer to > > convert from QemuOpts into structured QAPI block layer structs at a > > future date. It is already used by one of Max's patch series, and > > recent patches for glusterfs multiple-host support could have made > > use of it to simplify code. > > I haven't looked at the final patch because that one is irrelevant for > me, but otherwise nice series. > > Please keep me copied on new versions of it, I noticed that > qdict_crumple() and qobject_string_visitor_new() are exactly what I need > for implementing the new '-blockdev' option, so I'll build on top of > this. That's entirely intentional :-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|