Re: [Outreachy kernel] [PATCH 5/6] staging: lustre: Remove unnecessary 'return'

[Rehas Sachdeva <aquannie@gmail.com>]

On Thu, Sep 15, 2016 at 10:10:49AM +0200, Julia Lawall wrote:
> On Thu, 15 Sep 2016, Rehas Sachdeva wrote:
> 
> > Fixes checkpatch.pl warning:
> > WARNING: void function return statements are not generally useful.
> 
> It would be better to say what you did, rather than saying fix.  Here you
> could say:
> 
> Remove unnecessary void return at the end of a function.  Issue detected
> by checkpatch.
> 
> julia
> 

Hi Julia,
Please take a look at v2. Also please suggest if I should make similar
changes to the commit messages on other patches in this patchset as well.
Thanks.

Rehas

> 
> >
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> >  drivers/staging/lustre/lustre/llite/rw.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> > index bb85d16..23747fa 100644
> > --- a/drivers/staging/lustre/lustre/llite/rw.c
> > +++ b/drivers/staging/lustre/lustre/llite/rw.c
> > @@ -667,7 +667,6 @@ static void ras_update_stride_detector(struct ll_readahead_state *ras,
> >  	ras->ras_stride_length = stride_gap + ras->ras_consecutive_pages;
> >
> >  	RAS_CDEBUG(ras);
> > -	return;
> >  }
> >
> >  /* Stride Read-ahead window will be increased inc_len according to
> > @@ -883,7 +882,6 @@ out_unlock:
> >  	RAS_CDEBUG(ras);
> >  	ras->ras_request_index++;
> >  	spin_unlock(&ras->ras_lock);
> > -	return;
> >  }
> >
> >  int ll_writepage(struct page *vmpage, struct writeback_control *wbc)
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/bfedf0128abd4c08512b015481be1d5fd1d0d01e.1473923837.git.aquannie%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >