From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkYG7-0001dN-2K for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkYG1-0000Hr-UW for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:07:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkYG1-0000HZ-OL for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:07:21 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9CC9D7F7B0 for ; Thu, 15 Sep 2016 15:07:20 +0000 (UTC) Date: Thu, 15 Sep 2016 16:07:17 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160915150716.GC2083@work-vm> References: <1473949287-31122-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473949287-31122-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org * Paolo Bonzini (pbonzini@redhat.com) wrote: > /me hides in the corner... > > Cc: Dave Gilbert > Signed-off-by: Paolo Bonzini > --- > hw/i386/kvm/apic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c > index 5d140b9..feb0002 100644 > --- a/hw/i386/kvm/apic.c > +++ b/hw/i386/kvm/apic.c > @@ -141,7 +141,6 @@ static void kvm_apic_put(void *data) > > static void kvm_apic_post_load(APICCommonState *s) > { > - fprintf(stderr, "%s: Yeh\n", __func__); > run_on_cpu(CPU(s->cpu), kvm_apic_put, s); > } Hmm, I think you picked up the debug version we exchanged privately rather than the one I actually posted which I'd excised the debug from: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02658.html I think the only other change was that the one I posted I'd reformatted kvm_put_apic_state so it wasn't 81 characters long. Dave > > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK