Re: [PATCH] staging: olpc_dcon: Prefer using the BIT macro

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Sep 15, 2016 at 08:41:58PM +0530, Anchal Jain wrote:
> Replace all occurences of (1<<x) by BIT(x) in the file olpc_dcon.h to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro"
> 
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
> index 215e7ec..23a48a1 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.h
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.h
> @@ -9,18 +9,18 @@
>  #define DCON_REG_ID		 0
>  #define DCON_REG_MODE		 1
>  
> -#define MODE_PASSTHRU	(1<<0)
> -#define MODE_SLEEP	(1<<1)
> -#define MODE_SLEEP_AUTO	(1<<2)
> -#define MODE_BL_ENABLE	(1<<3)
> -#define MODE_BLANK	(1<<4)
> -#define MODE_CSWIZZLE	(1<<5)
> -#define MODE_COL_AA	(1<<6)
> -#define MODE_MONO_LUMA	(1<<7)
> -#define MODE_SCAN_INT	(1<<8)
> -#define MODE_CLOCKDIV	(1<<9)
> -#define MODE_DEBUG	(1<<14)
> -#define MODE_SELFTEST	(1<<15)
> +#define MODE_PASSTHRU	bit(0)
> +#define MODE_SLEEP	bit(1)
> +#define MODE_SLEEP_AUTO	bit(2)
> +#define MODE_BL_ENABLE	bit(3)
> +#define MODE_BLANK	bit(4)
> +#define MODE_CSWIZZLE	bit(5)
> +#define MODE_COL_AA	bit(6)
> +#define MODE_MONO_LUMA	bit(7)
> +#define MODE_SCAN_INT	bit(8)
> +#define MODE_CLOCKDIV	bit(9)
> +#define MODE_DEBUG	bit(14)
> +#define MODE_SELFTEST	bit(15)

did you build this patch?

Please do so before sending in changes, it will save everyone a lot of
time :)

thanks,

greg k-h