All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anchal Jain <anchalj109@gmail.com>
Cc: outreachy-kernel@googlegroups.com, jon.nettleton@gmail.com
Subject: Re: [PATCH v2] staging: olpc_dcon: Prefer using the BIT macro
Date: Thu, 15 Sep 2016 19:25:23 +0200	[thread overview]
Message-ID: <20160915172523.GA20506@kroah.com> (raw)
In-Reply-To: <20160915154838.GA7175@life-desktop>

On Thu, Sep 15, 2016 at 09:18:46PM +0530, Anchal Jain wrote:
> This patch fix the CHECK
> CHECK: Prefer using the BIT macro
> detected by checkpatch.pl
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> 	changes in v2:
> 		-modify commit message

You're previous commit message was a bit better :)

And again, did you build test this?  Just looking at it, I do not think
it will...

thanks,

greg k-h


  reply	other threads:[~2016-09-15 17:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 15:48 [PATCH v2] staging: olpc_dcon: Prefer using the BIT macro Anchal Jain
2016-09-15 17:25 ` Greg KH [this message]
2016-09-15 17:51   ` Anchal Jain
2016-09-16  8:20     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915172523.GA20506@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anchalj109@gmail.com \
    --cc=jon.nettleton@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.