From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bkYRA-0002Zv-RV
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:18:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bkYR6-0003sW-Ih
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:18:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34294)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bkYR6-0003sR-D7
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:18:48 -0400
Date: Thu, 15 Sep 2016 18:18:46 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160915181807-mutt-send-email-mst@kernel.org>
References: <1473847310-129729-1-git-send-email-imammedo@redhat.com>
	<1473847310-129729-2-git-send-email-imammedo@redhat.com>
	<20160915141909.GA6002@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160915141909.GA6002@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by
 adding 2.8 machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, longpeng2@huawei.com, marcel@redhat.com

On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote:
> On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote:
> > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend
> > PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in
> > 
> >     {\
> >         .driver   = "virtio-pci",\
> >         .property = "page-per-vq",\
> >         .value    = "on",\
> >     },
> > 
> > and
> > 
> >     {\
> >         .driver   = TYPE_X86_CPU,\
> >         .property = "l3-cache",\
> >         .value    = "off",\
> >     },
> > 
> > being ignored and as result change PC_COMPAT_2_6 behaviour.
> > 
> [...]
> >  #define PC_COMPAT_2_6 \
> > +    PC_COMPAT_2_7 \
> >      HW_COMPAT_2_6 \
> >      {\
> >          .driver   = "fw_cfg_io",\
> 
> Isn't this supposed to be unnecessary since commit bacc344c
> ("machine: add properties to compat_props incrementaly")?
> 
> -- 
> Eduardo


Indeed, I tested page-per-vq and it seems on for 2.6.
Igor, Marcel, could you comment pls?


-- 
MST