From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkjSQ-0002Lz-DD for qemu-devel@nongnu.org; Thu, 15 Sep 2016 23:04:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkjSN-0002fy-6P for qemu-devel@nongnu.org; Thu, 15 Sep 2016 23:04:54 -0400 Date: Fri, 16 Sep 2016 13:04:40 +1000 From: David Gibson Message-ID: <20160916030440.GA12262@voom.fritz.box> References: <1473878907-10477-1-git-send-email-lvivier@redhat.com> <20160915000934.GZ15077@voom.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20160915000934.GZ15077@voom.fritz.box> Subject: Re: [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2016 at 10:09:34AM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 08:48:22PM +0200, Laurent Vivier wrote: > > Define and use trace_spapr_XXX functions instead of > > DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_rtas, > > spapr_llan, spapr_vscsi. > >=20 > > This allows to enable dynamically (instead of recompiling the source) > > the traces for these devices. Messages are close as possible as > > messages used by DPRINTF. Sometime, I've removed some text to > > avoid redundancy between information given by the tracing function name > > and the text displayed. I've also updated print format to use > > the good conversion specifier ('u' instead of 'd' when the type is unsi= gned, > > PRIx32 instead of 'x' when the type is uint32_t or int32_t, ...) >=20 > I've removed the blank likes that Eric Blake mentioned, and applied to > ppc-for-2.8. Sorry, I've taken 5/5 the vscsi one out again. It breaks compile with --enable-trace-backend=3Dust, and I haven't had a chance to debug it so far. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX22FHAAoJEGw4ysog2bOS+/EQAJU03Jrec1BWEiU9cubKZMuO iYHj3+956gtiVmpNJyyg8s9003PC32UJLzxdVr4jK4fohtDh2XzhsUf8A5TXWYXz Tu4tQlloV17GopJsiWQQQCoL4gamFqk6TIvRcJ43tYhaGLYPw3wjK0vtfrkb69Zx YtvQb3R0Ja1ZftqLiJc9kmZlj9EhrRuzLeDCkSkgP2duDdUro8UiWnZn1OlOAowr HesdyZc5sFyhOYM7w8+B6c9yCZjGEtJEL8ro25exxNRH5BmxQfIHJtWN1/xAvQUI 2VdCSp0KXIZh/5cPJVT2uqc0qFF6mdfsrQPvmeYvTpnTCB5G1ndVHGv5WpqO/5i+ rjqCxpsJ0rh4g0ksbCd+VNAzNLnYc8K80eU0hnClyzA75poKsaXw1Z5te12Rl/pj UcLICeB5UNH/aph5pzPP7cNj8BQnPkw0gFWY76JjW6uevDVBZCF9NL2cYitMGrlc B08iYI9S+YTX6d65Lo7G8iG5IrAcn8R2l/b6Qb5RGMJmspQH41iem1PXKl+oDQ+J H1TguSBrscP0Q5PUT5iS2vLdrRpevy6vrwr8DhKy5pRS6SHPQ0ekFmxvcprTB0YG Q8+rXnKiGRuFMHC58AM6qKTVwEW6TaVVTFeeSAW9cTXYTTp1BCytM8PuN47VL4UD 5E8IxTfCH4Yi9DZC+pyg =7VYT -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--