From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1bknjI-000729-4V
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 03:38:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1bknjD-0006ED-2m
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 03:38:35 -0400
Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::12]:59670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1bknjC-0006Dw-P8
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 03:38:31 -0400
Date: Fri, 16 Sep 2016 09:38:23 +0200
From: Olaf Hering <olaf@aepfle.de>
Message-ID: <20160916073823.GB28560@aepfle.de>
References: <20160902094354.25935-1-olaf@aepfle.de>
	<20160902094354.25935-3-olaf@aepfle.de>
	<alpine.DEB.2.10.1609141851040.26423@sstabellini-ThinkPad-X260>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="FkmkrVfFsRoUs1wW"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1609141851040.26423@sstabellini-ThinkPad-X260>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug
 for emulated PCI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony Perard <anthony.perard@citrix.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org


--FkmkrVfFsRoUs1wW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 14, Stefano Stabellini wrote:

> The doc says:
>=20
> "If VMDP was configured to control just NIC devices it would write the
> value 0x1 to offset 0x8. If VMDP was configured to control just storage
> devices it would write the value 0x2 to offset 0x8."
>=20
> So 0x1 to 0x8 to unplug NICs, otherwise 0x2 to 0x8 to unplug storage.
> The switch above does the opposite. What am I missing? Am I misreading
> the document?

The doc is wrong, this is what qemu-trad does:

+    case 8:
+       if (val =3D=3D1 ) {
+               fprintf(logfile, "Disconnect IDE hard disk...\n");
+               ide_unplug_harddisks();
+               fprintf(logfile, "Done.\n");
+       } else if (val =3D=3D 2) {
+               fprintf(logfile, "Disconnect netifs...\n");
+               pci_unplug_netifs();
+               fprintf(logfile, "Shutdown taps...\n");
+               net_tap_shutdown_all();
+               fprintf(logfile, "Done.\n");
+       }
+       break;

Olaf

--FkmkrVfFsRoUs1wW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAlfboW8ACgkQXUKg+qaYNn6JkQCgkbUW2hrvi2t4jVTGcdK9gJtm
OUgAoLCOXX51z03vraH75o7wq14uKBcl
=adc+
-----END PGP SIGNATURE-----

--FkmkrVfFsRoUs1wW--