From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Brian Gerst <brgerst@gmail.com>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Byungchul Park <byungchul.park@lge.com>,
Nilay Vaish <nilayvaish@gmail.com>
Subject: Re: [PATCH 0/6] x86/dumpstack: replace dump_trace() with a new unwinder
Date: Fri, 16 Sep 2016 11:16:16 +0200 [thread overview]
Message-ID: <20160916091616.GA5900@gmail.com> (raw)
In-Reply-To: <cover.1473954749.git.jpoimboe@redhat.com>
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> The last version was posted as part of a much larger patch set:
>
> https://lkml.kernel.org/r/cover.1471525031.git.jpoimboe@redhat.com
>
> People complained about the set being too big, so it was split up into
> more digestible pieces. All the prerequisite patches for the unwinder
> have now been merged.
>
> See patch 1/6 for the background and justification for this change.
>
> Josh Poimboeuf (6):
> x86/unwind: add new unwind interface and implementations
> perf/x86: convert perf_callchain_kernel() to use the new unwinder
> x86/stacktrace: convert save_stack_trace_*() to use the new unwinder
> oprofile/x86: convert x86_backtrace() to use the new unwinder
> x86/dumpstack: convert show_trace_log_lvl() to use the new unwinder
> x86/dumpstack: remove dump_trace() and related callbacks
>
> arch/x86/events/core.c | 33 +++-----
> arch/x86/include/asm/stacktrace.h | 46 +---------
> arch/x86/include/asm/unwind.h | 74 ++++++++++++++++
> arch/x86/kernel/Makefile | 6 ++
> arch/x86/kernel/dumpstack.c | 174 +++++++++++++++++---------------------
> arch/x86/kernel/dumpstack_32.c | 44 +---------
> arch/x86/kernel/dumpstack_64.c | 78 +----------------
> arch/x86/kernel/stacktrace.c | 74 +++++++---------
> arch/x86/kernel/unwind_frame.c | 93 ++++++++++++++++++++
> arch/x86/kernel/unwind_guess.c | 43 ++++++++++
> arch/x86/oprofile/backtrace.c | 39 ++++-----
> 11 files changed, 362 insertions(+), 342 deletions(-)
> create mode 100644 arch/x86/include/asm/unwind.h
> create mode 100644 arch/x86/kernel/unwind_frame.c
> create mode 100644 arch/x86/kernel/unwind_guess.c
Looks good to me, but could you please rebase it on top of very latestest -tip,
which has these bits from Andy included:
1959a60182f4 x86/dumpstack: Pin the target stack when dumping it
cb76c9398240 x86/dumpstack: Add get_stack_info() interface
... which create new conflicts with your series.
Thanks,
Ingo
prev parent reply other threads:[~2016-09-16 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:55 [PATCH 0/6] x86/dumpstack: replace dump_trace() with a new unwinder Josh Poimboeuf
2016-09-15 15:55 ` [PATCH 1/6] x86/unwind: add new unwind interface and implementations Josh Poimboeuf
2016-09-15 15:55 ` [PATCH 2/6] perf/x86: convert perf_callchain_kernel() to use the new unwinder Josh Poimboeuf
2016-09-15 15:55 ` [PATCH 3/6] x86/stacktrace: convert save_stack_trace_*() " Josh Poimboeuf
2016-09-15 15:55 ` [PATCH 4/6] oprofile/x86: convert x86_backtrace() " Josh Poimboeuf
2016-09-15 15:56 ` [PATCH 5/6] x86/dumpstack: convert show_trace_log_lvl() " Josh Poimboeuf
2016-09-15 15:56 ` [PATCH 6/6] x86/dumpstack: remove dump_trace() and related callbacks Josh Poimboeuf
2016-09-16 9:16 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916091616.GA5900@gmail.com \
--to=mingo@kernel.org \
--cc=brgerst@gmail.com \
--cc=byungchul.park@lge.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nilayvaish@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.