All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Filipe Manco <filipe.manco@neclab.eu>
Cc: <netdev@vger.kernel.org>, <wei.liu2@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] xen-netback: fix error handling on netback_probe()
Date: Fri, 16 Sep 2016 12:30:18 +0100	[thread overview]
Message-ID: <20160916113018.GC21888@citrix.com> (raw)
In-Reply-To: <1473952246-27037-1-git-send-email-filipe.manco@neclab.eu>

On Thu, Sep 15, 2016 at 05:10:46PM +0200, Filipe Manco wrote:
> In case of error during netback_probe() (e.g. an entry missing on the
> xenstore) netback_remove() is called on the new device, which will set
> the device backend state to XenbusStateClosed by calling
> set_backend_state(). However, the backend state wasn't initialized by
> netback_probe() at this point, which will cause and invalid transaction
> and set_backend_state() to BUG().
> 
> Initialize the backend state at the beginning of netback_probe() to
> XenbusStateInitialising, and create two new valid state transitions on
> set_backend_state(), from XenbusStateInitialising to XenbusStateClosed,
> and from XenbusStateInitialising to XenbusStateInitWait.
> 
> Signed-off-by: Filipe Manco <filipe.manco@neclab.eu>

Acked-by: Wei Liu <wei.liu2@citrix.com>

  reply	other threads:[~2016-09-16 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 15:10 [PATCH v2] xen-netback: fix error handling on netback_probe() Filipe Manco
2016-09-16 11:30 ` Wei Liu [this message]
2016-09-16 11:30 ` Wei Liu
2016-09-17 13:56 ` David Miller
2016-09-17 13:56 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2016-09-15 15:10 Filipe Manco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916113018.GC21888@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=filipe.manco@neclab.eu \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.