From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Cc: Wei Fang <fangwei1@huawei.com>,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
jack@suse.com, axboe@kernel.dk, tj@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput()
Date: Fri, 16 Sep 2016 13:10:23 +0100 [thread overview]
Message-ID: <20160916121023.GX2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <57DBA3FF.4080201@oracle.com>
On Fri, Sep 16, 2016 at 01:19:19PM +0530, Vaishali Thakkar wrote:
> Hi,
>
> Just a question regarding this change. As after this change
> dput() is sleepable, is it still safe to use if under the
> spinlock in the function d_prune_aliases?
It has always been sleepable and it wouldn't have been safe to use
under spinlocks. Which d_prune_aliases() does not do - __dentry_kill()
is called with dentry, its parent and its inode (if present) all locked and
it drops all those locks before returning.
next prev parent reply other threads:[~2016-09-16 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 3:01 [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() Wei Fang
2016-06-22 6:51 ` Boqun Feng
2016-07-06 2:36 ` Wei Fang
2016-09-16 7:49 ` Vaishali Thakkar
2016-09-16 12:10 ` Al Viro [this message]
2016-09-16 12:50 ` Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916121023.GX2356@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=fangwei1@huawei.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.