All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict
Date: Fri, 16 Sep 2016 14:51:24 +0200	[thread overview]
Message-ID: <20160916125124.GG4633@noname.redhat.com> (raw)
In-Reply-To: <cover.1473950317.git.berto@igalia.com>

Am 15.09.2016 um 16:52 hat Alberto Garcia geschrieben:
> This series adds "read-only" to the options QDict, fixing a
> long-standing problem with the reopening code.
> 
>    [E] <- [D] <- [C] <- [B] <- [A]
> 
> In a normal scenario, the active layer [A] is in read-write mode and
> everything else is read-only. If we reopen [D] in read-write mode and
> later reopen [B], then [D] will become read-only when inheriting the
> flags from its parent (see bdrv_backing_options()). With this series,
> inheriting options doesn't need to override values that have been
> explicitly set before.
> 
> The BDRV_O_RDWR flag is not removed yet, but its keep in sync with the
> value of the "read-only" option. Removing the BDRV_O_RDWR flag is not
> straightforward in all cases and can result in code that is
> significantly slower and less readable. Therefore it will be dealt
> with in the future.

Thanks, applied to the block branch.

Kevin

      parent reply	other threads:[~2016-09-16 12:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 14:52 [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict Alberto Garcia
2016-09-15 14:52 ` [Qemu-devel] [PATCH v2 1/7] block: Remove bdrv_is_snapshot Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 3/7] block: Update bs->open_flags earlier in bdrv_open_common() Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 4/7] block: Add "read-only" to the options QDict Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 5/7] block: Don't queue the same BDS twice in bdrv_reopen_queue_child() Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 6/7] commit: Add 'base' to the reopen queue before 'overlay_bs' Alberto Garcia
2016-09-15 14:53 ` [Qemu-devel] [PATCH v2 7/7] block: rename "read-only" to BDRV_OPT_READ_ONLY Alberto Garcia
2016-09-16 12:51 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916125124.GG4633@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.