From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6330674938515554304 X-Received: by 10.157.46.180 with SMTP id w49mr50695ota.81.1474030499253; Fri, 16 Sep 2016 05:54:59 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.174.38 with SMTP id x38ls1756790ioe.42.gmail; Fri, 16 Sep 2016 05:54:58 -0700 (PDT) X-Received: by 10.36.4.65 with SMTP id 62mr44458itb.20.1474030498630; Fri, 16 Sep 2016 05:54:58 -0700 (PDT) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id 142si4228154pfx.2.2016.09.16.05.54.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Sep 2016 05:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (pes75-3-78-192-101-3.fbxo.proxad.net [78.192.101.3]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A99C69C; Fri, 16 Sep 2016 12:54:57 +0000 (UTC) Date: Fri, 16 Sep 2016 14:55:02 +0200 From: Greg Kroah-Hartman To: Rehas Sachdeva Cc: outreachy-kernel@googlegroups.com, Sudip Mukherjee , Teddy Wang Subject: Re: [PATCH 3/5] staging: sm750fb: Remove multiple assignments Message-ID: <20160916125502.GA29701@kroah.com> References: <20160916074859.GB20608@kroah.com> <20160916123439.GA15179@toblerone> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160916123439.GA15179@toblerone> User-Agent: Mutt/1.7.0 (2016-08-17) On Fri, Sep 16, 2016 at 06:04:39PM +0530, Rehas Sachdeva wrote: > On Fri, Sep 16, 2016 at 09:48:59AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 16, 2016 at 03:03:02AM +0530, Rehas Sachdeva wrote: > > > Fixes multiple assignments of the form 'x = y = k' to 'x = k; y = k;'. Issue > > > detected by checkpatch. > > > > > > Signed-off-by: Rehas Sachdeva > > > --- > > > drivers/staging/sm750fb/sm750.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > > > index 7d90e25..9f1b591 100644 > > > --- a/drivers/staging/sm750fb/sm750.c > > > +++ b/drivers/staging/sm750fb/sm750.c > > > @@ -365,7 +365,8 @@ static int lynxfb_ops_set_par(struct fb_info *info) > > > ret = -EINVAL; > > > break; > > > } > > > - var->height = var->width = -1; > > > + var->height = -1; > > > + var->width = -1; > > > > that's an odd change, isn't the first version of all of these more > > readable? > > > > thanks, > > > > greg k-h > > Hi Greg, > > This is an odd change indeed, something I saw only in sm750fb, among so many > other drivers. Does that mean that for the sake of uniformity, we should go > ahead with this? Although the first version looks better somehow. I recommend just leaving it alone, thanks. greg k-h