All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bill O'Donnell" <billodo@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_quota: Enable 3 more foreign commands
Date: Fri, 16 Sep 2016 08:30:27 -0500	[thread overview]
Message-ID: <20160916133027.GA12342@redhat.com> (raw)
In-Reply-To: <5fe315ee-1198-ca43-16a0-13562ced179e@redhat.com>

On Thu, Sep 15, 2016 at 04:53:51PM -0500, Eric Sandeen wrote:
> Enable restore, limit, and timer.
> 
> Unsupported commands remain, for lack of kernel support, generally:
> warn, quot,, enable, disable, and remove.
> 
> xfs_quota> report
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> 
> xfs_quota> restore -f quotadump
> xfs_quota> report
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> testuser            0      16384      32768     00 [--------]
> fsgqa               0     102400     112640     00 [--------]
> 
> xfs_quota> limit bsoft=200m fsgqa
> 
> xfs_quota> report 
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> testuser            0      16384      32768     00 [--------]
> fsgqa               0     204800     112640     00 [--------]
> 
> xfs_quota> state -u
> User quota state on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>   Accounting: ON
>   Enforcement: ON
>   Inode: #12 (16 blocks, 1 extents)
> Blocks grace time: [7 days]
> Inodes grace time: [7 days]
> 
> xfs_quota> timer -b 3days
> xfs_quota> state -u
> User quota state on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>   Accounting: ON
>   Enforcement: ON
>   Inode: #12 (16 blocks, 1 extents)
> Blocks grace time: [3 days]
> Inodes grace time: [7 days]
> Realtime Blocks grace time: [--------]
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> diff --git a/quota/edit.c b/quota/edit.c
> index e5ddc8c..36b327a 100644
> --- a/quota/edit.c
> +++ b/quota/edit.c
> @@ -709,6 +709,7 @@ edit_init(void)
>  	_("[-g|-p|-u] bsoft|bhard|isoft|ihard|rtbsoft|rtbhard=N -d|id|name");
>  	limit_cmd.oneline = _("modify quota limits");
>  	limit_cmd.help = limit_help;
> +	limit_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>  	restore_cmd.name = "restore";
>  	restore_cmd.cfunc = restore_f;
> @@ -716,6 +717,7 @@ edit_init(void)
>  	restore_cmd.argmax = -1;
>  	restore_cmd.args = _("[-g|-p|-u] [-f file]");
>  	restore_cmd.oneline = _("restore quota limits from a backup file");
> +	restore_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>  	timer_cmd.name = "timer";
>  	timer_cmd.cfunc = timer_f;
> @@ -724,6 +726,7 @@ edit_init(void)
>  	timer_cmd.args = _("[-bir] [-g|-p|-u] value");
>  	timer_cmd.oneline = _("set quota enforcement timeouts");
>  	timer_cmd.help = timer_help;
> +	timer_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>  	warn_cmd.name = "warn";
>  	warn_cmd.cfunc = warn_f;
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2016-09-16 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 21:53 [PATCH] xfs_quota: Enable 3 more foreign commands Eric Sandeen
2016-09-16 13:30 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916133027.GA12342@redhat.com \
    --to=billodo@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.