From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH net] sctp: fix SSN comparision
Date: Fri, 16 Sep 2016 13:40:47 +0000 [thread overview]
Message-ID: <20160916134047.GD3200@localhost.localdomain> (raw)
In-Reply-To: <9f22e4725d836feda1b2c2483303adb30838216f.1473962178.git.marcelo.leitner@gmail.com>
On Fri, Sep 16, 2016 at 01:33:47PM +0000, David Laight wrote:
> > > -static inline int ADDIP_SERIAL_gte(__u16 s, __u16 t)
> > > +static inline int ADDIP_SERIAL_gte(__u32 s, __u32 t)
> > > {
> > > return ((s) = (t)) || (((t) - (s)) & ADDIP_SERIAL_SIGN_BIT);
> > > }
>
> Does gcc manage to compile that to (s32)((t) - (s)) <= 0 ?
I have no idea but I have a patch in the works for updating it to this
form, to be more like time_after(). Will probably post it by next week.
Marcelo
next prev parent reply other threads:[~2016-09-16 13:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 18:02 [PATCH net] sctp: fix SSN comparision Marcelo Ricardo Leitner
2016-09-15 18:02 ` Marcelo Ricardo Leitner
2016-09-16 13:13 ` Neil Horman
2016-09-16 13:13 ` Neil Horman
2016-09-16 13:33 ` David Laight
2016-09-16 13:40 ` Marcelo Ricardo Leitner [this message]
2016-09-16 13:45 ` Marcelo Ricardo Leitner
2016-09-16 14:17 ` David Laight
2016-09-16 14:46 ` 'Marcelo Ricardo Leitner'
2016-09-16 14:53 ` 'Marcelo Ricardo Leitner'
2016-09-16 15:13 ` David Laight
2016-09-16 17:21 ` 'Marcelo Ricardo Leitner'
2016-09-17 14:00 ` David Miller
2016-09-17 14:00 ` David Miller
2016-09-19 10:41 ` David Laight
2016-09-19 16:02 ` 'Marcelo Ricardo Leitner'
2016-09-19 21:21 ` 'Marcelo Ricardo Leitner'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916134047.GD3200@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.