From: Greg Kurz <groug@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916
Date: Fri, 16 Sep 2016 19:36:57 +0200 [thread overview]
Message-ID: <20160916193657.0f00a7e6@bahia> (raw)
In-Reply-To: <CAFEAcA_CmCsOTbTL3NSGoXPitCqVJobZ_1WiR2ON948+e0MWJg@mail.gmail.com>
On Fri, 16 Sep 2016 15:46:26 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 16 September 2016 at 15:39, Greg Kurz <groug@kaod.org> wrote:
> > Ok, I'll look into it... but the important part in this pull request is
> > the "9pfs: fix potential segfault during walk" patch. It fixes a regression
> > introduced in 2.7 by the 9P security fixes. And IIUC, Michael Roth is about
> > to release 2.6.1.1 with these fixes and the regression...
> >
> > Should I send a new pull request without the qtest patches ? Or with the
> > regression fix only ?
>
> That's up to you, as long as you don't break "make check".
> You probably want to investigate at least enough to be happy that
> this problem is a bug in the test code, not the feature itself.
>
It is the test code actually: 9P uses little-endian ordering :)
I'll post an updated version which doesn't break "make check" on both
BE and LE hosts, and re-send a pull request.
Cheers.
--
Greg
> thanks
> -- PMM
prev parent reply other threads:[~2016-09-16 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 13:09 [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916 Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 1/8] 9pfs: drop unused fmt strings in the proxy backend Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 2/8] 9pfs: drop duplicate line in " Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 3/8] 9pfs: drop useless v9fs_string_null() function Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 4/8] 9pfs: introduce v9fs_path_sprintf() helper Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 5/8] tests: virtio-9p: introduce start/stop functions Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 6/8] tests: virtio-9p: add basic configuration test Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 7/8] tests: virtio-9p: add basic transaction test Greg Kurz
2016-09-16 13:09 ` [Qemu-devel] [PULL 8/8] 9pfs: fix potential segfault during walk Greg Kurz
2016-09-16 14:25 ` [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916 Peter Maydell
2016-09-16 14:39 ` Greg Kurz
2016-09-16 14:46 ` Peter Maydell
2016-09-16 17:36 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916193657.0f00a7e6@bahia \
--to=groug@kaod.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.