From: Sandhya Bankar <bankarsandhya512@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, oleg.drokin@intel.com,
andreas.dilger@intel.com, jsimmons@infradead.org
Subject: [PATCH v2] Staging: lustre: Convert array index from the loop bound to the loop index.
Date: Sat, 17 Sep 2016 03:01:06 +0530 [thread overview]
Message-ID: <20160916213106.GA4147@sandhya> (raw)
Convert array index from the loop bound to the loop index.
The structure cl_env_percpu[NR_CPUS] has been initializing for each
possible cpu (i.e 0 to i) but during initialization if any error will
occurred this come to the error handling code which should uninitialize
the cl_env_percpu upto i but currently cleanup is happening repeatedly for
the same cl_env_percpu[i] element which does not seems to be correct.
Used below semantic patch to identify this issue:
@@
expression e1,e2,ar;
@@
for(e1 = 0; e1 < e2; e1++) { <...
ar[
- e2
+ e1
]
...> }
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v2:
*Correcting the commit message.
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 91a5806..eeccd30 100755
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -1000,7 +1000,7 @@ static int cl_env_percpu_init(void)
* thus we must uninitialize up to i, the rest are undefined.
*/
for (j = 0; j < i; j++) {
- cle = &cl_env_percpu[i];
+ cle = &cl_env_percpu[j];
lu_context_exit(&cle->ce_ses);
lu_context_fini(&cle->ce_ses);
lu_env_fini(&cle->ce_lu);
--
1.7.1
next reply other threads:[~2016-09-17 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 21:31 Sandhya Bankar [this message]
2016-09-17 8:47 ` [Outreachy kernel] [PATCH v2] Staging: lustre: Convert array index from the loop bound to the loop index Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916213106.GA4147@sandhya \
--to=bankarsandhya512@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=oleg.drokin@intel.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.