From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, tom@herbertland.com,
bblanco@plumgrid.com, rana.shahot@gmail.com,
"David S. Miller\" <davem@davemloft.net>,
brouer@redhat.com"@redhat.com
Subject: Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full
Date: Fri, 16 Sep 2016 22:29:43 +0200 [thread overview]
Message-ID: <20160916222943.6a2ea073@redhat.com> (raw)
In-Reply-To: <1474056050.22679.75.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, 16 Sep 2016 13:00:50 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> > index 2040dad8611d..d414c67dfd12 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> > @@ -906,6 +906,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
> > length, tx_index,
> > &doorbell_pending))
> > goto consumed;
> > + goto next;
> > break;
>
> Why keeping this break; then ? ;)
I'll send a V2
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-09-16 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 19:47 [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full Jesper Dangaard Brouer
2016-09-16 20:00 ` Eric Dumazet
2016-09-16 20:29 ` Jesper Dangaard Brouer [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-16 20:36 Jesper Dangaard Brouer
2016-09-16 20:37 ` Jesper Dangaard Brouer
2016-09-16 20:43 ` Brenden Blanco
2016-09-17 14:46 ` Jesper Dangaard Brouer
2016-09-19 5:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916222943.6a2ea073@redhat.com \
--to=brouer@redhat.com \
--cc="David S. Miller\" <davem@davemloft.net>, brouer@redhat.com"@redhat.com \
--cc=bblanco@plumgrid.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rana.shahot@gmail.com \
--cc=tariqt@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.