From: Stephen Boyd <sboyd@codeaurora.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Jay Sternberg" <jay.e.sternberg@intel.com>,
"Jens Axboe" <axboe@fb.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Matias Bjørling" <m@bjorling.me>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Alan Tull" <atull@opensource.altera.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Valentin Rothberg" <valentinrothberg@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] clk: probe common clock drivers earlier
Date: Fri, 16 Sep 2016 16:12:45 -0700 [thread overview]
Message-ID: <20160916231245.GX7243@codeaurora.org> (raw)
In-Reply-To: <CAK7LNATY9wTjHjsLtGHAJ-DueqXcCHdrw_uoSfyTOEmpp-ZPGw@mail.gmail.com>
On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Greg,
>
>
> 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Several SoCs implement platform drivers for clocks rather than
> > CLK_OF_DECLARE(). Clocks should come earlier because they are
> > prerequisites for many of other drivers. It will help to mitigate
> > EPROBE_DEFER issues.
> >
> > Also, drop the comment since it does not look valuable.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> > - Move clk/ above dma/ since DMA drivers generally enable clk
> >
> > drivers/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 8f5d076..ff39051 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
> > # was used and do nothing if so
> > obj-$(CONFIG_PNP) += pnp/
> > obj-y += amba/
> > +
> > +obj-y += clk/
> > # Many drivers will want to use DMA so this has to be made available
> > # really early.
> > obj-$(CONFIG_DMADEVICES) += dma/
> > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
> > obj-$(CONFIG_VLYNQ) += vlynq/
> > obj-$(CONFIG_STAGING) += staging/
> > obj-y += platform/
> > -#common clk code
> > -obj-y += clk/
> >
> > obj-$(CONFIG_MAILBOX) += mailbox/
> > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
>
>
> What do you think of this patch?
>
I assumed Greg would pick it up given that Mike already acked it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-09-16 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:49 [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada
2016-09-16 7:53 ` Masahiro Yamada
2016-09-16 23:12 ` Stephen Boyd [this message]
2016-09-17 8:56 ` Greg Kroah-Hartman
2016-09-18 16:25 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916231245.GX7243@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=atull@opensource.altera.com \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=jay.e.sternberg@intel.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bjorling.me \
--cc=mturquette@baylibre.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=valentinrothberg@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.