From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC: PATCH 2/3] system: allow auto net configuration with networkd
Date: Sat, 17 Sep 2016 14:17:41 +0200 [thread overview]
Message-ID: <20160917141741.19bfecde@free-electrons.com> (raw)
In-Reply-To: <1474113519-24713-3-git-send-email-eric.le.bihan.dev@free.fr>
Hello,
On Sat, 17 Sep 2016 13:58:38 +0200, Eric Le Bihan wrote:
> Allow automatic network configuration via systemd-networkd if selected.
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Looks good to me, with one possible suggestion.
> -comment "automatic network configuration via DHCP needs ifupdown or busybox"
> - depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN)
> +comment "automatic network configuration via DHCP needs ifupdown or busybox or networkd"
> + depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || BR2_PACKAGE_SYSTEMD_NETWORKD)
I think I'd remove this comment entirely, I'm not sure it's very useful.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-17 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 11:58 [Buildroot] [RFC: PATCH 0/3] DHCP configuration via networkd Eric Le Bihan
2016-09-17 11:58 ` [Buildroot] [RFC: PATCH 1/3] systemd: configure DHCP " Eric Le Bihan
2016-09-17 12:16 ` Thomas Petazzoni
2017-02-06 17:49 ` Thomas Petazzoni
2016-09-17 11:58 ` [Buildroot] [RFC: PATCH 2/3] system: allow auto net configuration with networkd Eric Le Bihan
2016-09-17 12:17 ` Thomas Petazzoni [this message]
2017-02-06 17:50 ` Thomas Petazzoni
2016-09-17 11:58 ` [Buildroot] [RFC: PATCH 3/3] system: enable predictable net interface names Eric Le Bihan
2016-09-17 12:20 ` Thomas Petazzoni
2017-02-06 20:07 ` Peter Korsgaard
2017-03-10 21:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917141741.19bfecde@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.