Re: [Outreachy kernel] [PATCH 1/2] Staging: android: Modify argument of sizeof() to pointer variables.

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Sep 17, 2016 at 02:20:59AM +0530, Sandhya Bankar wrote:
> Modify arguments of sizeof() to pointer variables.
> The destination of the allocation has type struct **, so the
> elements of the array should have pointer type, not structure type.
> 
> These changes are made using below Coccinelle script:
> 
> @disable sizeof_type_expr@
> type T;
> T **x;
> @@
> 
>   x =
>   <+...sizeof(
> - T
> + *x
>   )...+>
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/android/ion/hisilicon/hi6220_ion.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..4f0dd4b 100755
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -57,7 +57,7 @@ static int hi6220_ion_probe(struct platform_device *pdev)
>  		return PTR_ERR(ipdev->data);
>  
>  	ipdev->heaps = devm_kzalloc(&pdev->dev,
> -				sizeof(struct ion_heap)*ipdev->data->nr,
> +				sizeof(*ipdev->heaps)*ipdev->data->nr,

You just changed the size of the memory you allocated, please always be
_VERY_ careful when making a change like this.  The original code is
correct, please leave it as-is.

thanks,

greg k-h