All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sandhya Bankar <bankarsandhya512@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
	thomas.petazzoni@free-electrons.com, noralf@tronnes.org
Subject: Re: [PATCH] Staging: fbtft: Use !x instead of x == NULL.
Date: Sat, 17 Sep 2016 23:27:15 +0200	[thread overview]
Message-ID: <20160917212715.GA5920@kroah.com> (raw)
In-Reply-To: <20160916090231.GA3940@sandhya>

On Fri, Sep 16, 2016 at 02:32:32PM +0530, Sandhya Bankar wrote:
> Use !x instead of x == NULL.
> This issue was found by checkpatch.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft_device.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
> index 924abd3..e921183 100755

How did this file get to be 0755 permissions?  What are you using to
edit this?  It is a virtual machine somehow?

Please be more careful in the future...

thanks,

greg k-h


  reply	other threads:[~2016-09-17 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  9:02 [PATCH] Staging: fbtft: Use !x instead of x == NULL Sandhya Bankar
2016-09-17 21:27 ` Greg KH [this message]
2016-09-17 21:28 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160917212715.GA5920@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bankarsandhya512@gmail.com \
    --cc=noralf@tronnes.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.