All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Namrata A Shettar <namrataashettar@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	Malcolm Priestley <tvboxspy@gmail.com>,
	Anson Jacob <ansonjacob.aj@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH 1/4] staging: vt6655: Replace explicit NULL comparison
Date: Sat, 17 Sep 2016 23:39:45 +0200	[thread overview]
Message-ID: <20160917213945.GA21575@kroah.com> (raw)
In-Reply-To: <241ad34249b77e68f1a52ebe7255747c77e43645.1474108445.git.namrataashettar@gmail.com>

On Sat, Sep 17, 2016 at 05:18:19PM +0530, Namrata A Shettar wrote:
> Replace explicit NULL comparison to resolve checkpatch issue.
> Comparing variable x with NULL same as !x in this case.
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  drivers/staging/vt6655/device_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You have 4 patches here, yet you only have 2 unique subjects.  Don't
have 2 different patches with the same subject line, that implies that
they are identical, right?

Please fix that up and resend this series.

thanks,

greg k-h


  reply	other threads:[~2016-09-17 21:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17 11:48 [PATCH 0/4] staging: vt6655: Fix checkpatch issues Namrata A Shettar
2016-09-17 11:48 ` [PATCH 1/4] staging: vt6655: Replace explicit NULL comparison Namrata A Shettar
2016-09-17 21:39   ` Greg Kroah-Hartman [this message]
2016-09-18  4:50     ` Namrata A Shettar
2016-09-17 11:48 ` [PATCH 2/4] " Namrata A Shettar
2016-09-17 11:48 ` [PATCH 3/4] staging: vt6655: Break multiple assignments Namrata A Shettar
2016-09-17 11:49 ` [PATCH 4/4] " Namrata A Shettar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160917213945.GA21575@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ansonjacob.aj@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=hamohammed.sa@gmail.com \
    --cc=namrataashettar@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.