From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Sun, 18 Sep 2016 15:03:20 +0800 Subject: [U-Boot] [PATCH v2 01/17] imx: iomux-v3: Fix build error with snvs base In-Reply-To: <1474058929-17637-2-git-send-email-jagan@amarulasolutions.com> References: <1474058929-17637-1-git-send-email-jagan@amarulasolutions.com> <1474058929-17637-2-git-send-email-jagan@amarulasolutions.com> Message-ID: <20160918070318.GB5473@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jagan, On Sat, Sep 17, 2016 at 02:18:33AM +0530, Jagan Teki wrote: >snvs base is added only for i.MX6ULL but the code is >added for common, so firing build error while compiling >other i.MX6 SOC's > >Issue observed with the below patch >"imx: mx6ull: Update memory map address" >(sha1: e8eac1b5b3a98a06426bc4867c03c38329841e5c) > >Build log: > CC arch/arm/imx-common/iomux-v3.o >arch/arm/imx-common/iomux-v3.c: In function 'imx_iomux_v3_setup_pad': >arch/arm/imx-common/iomux-v3.c:56:19: error: 'IOMUXC_SNVS_BASE_ADDR' undeclared (first use in this function) > base = (void *)IOMUXC_SNVS_BASE_ADDR; CONFIG_IOMUX_LPSR is only needed for i.MX7 and i.MX6ULL now. CONFIG_IOMUX_LPSR is defined in your configuration? I did not meet such build error. Regards, Peng. > >Cc: Stefano Babic >Cc: Peng Fan >Cc: Michael Trimarchi >Signed-off-by: Jagan Teki >--- > arch/arm/imx-common/iomux-v3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/arch/arm/imx-common/iomux-v3.c b/arch/arm/imx-common/iomux-v3.c >index 78f667e..efb884c 100644 >--- a/arch/arm/imx-common/iomux-v3.c >+++ b/arch/arm/imx-common/iomux-v3.c >@@ -50,7 +50,7 @@ void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad) > if (sel_input_ofs) > sel_input_ofs += IOMUX_LPSR_SEL_INPUT_OFS; > } >-#else >+#elif defined(CONFIG_MX6ULL) > if (is_mx6ull()) { > if (lpsr == IOMUX_CONFIG_LPSR) { > base = (void *)IOMUXC_SNVS_BASE_ADDR; >-- >2.7.4 >