All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Håvard Skinnemoen" <hskinnemoen@gmail.com>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'
Date: Sun, 18 Sep 2016 11:46:43 +0200	[thread overview]
Message-ID: <20160918094643.GA25728@samfundet.no> (raw)
In-Reply-To: <b1866e30-15c7-a348-b750-7378e0dc724b@roeck-us.net>

Around Sat 17 Sep 2016 13:09:17 -0700 or thereabout, Guenter Roeck wrote:
> On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote:
>>On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>avr32 builds fail with:
>>>
>>>arch/avr32/kernel/built-in.o: In function `arch_ptrace':
>>>(.text+0x650): undefined reference to `___copy_from_user'
>>>arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
>>>reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
>>>(.text+0x5dd8): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
>>>sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `ptrace_has_cap':
>>>ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
>>>kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
>>>`___copy_from_user' follow
>>>
>>>Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
>>>Cc: Al Viro <viro@zeniv.linux.org.uk>
>>>Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>>Right, gmail loves HTML. Let me try this again...
>>
>>Acked-by: Havard Skinnemoen <hskinnemoen@gmail.com>

Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>

>>Thanks!
>>
> You are welcome ... I'll wait until tomorrow to see if Al wants to send this
> patch and the patch for the openrisc failure to Linus; if I don't hear back,
> I'll do it myself.

Thanks, I have no other fixes for AVR32. But let me know if you want me to
push it through linux-avr32.

Why did not Al add Håvard/me to CC in the first place? That way we might have
avoided this build break in the first place?

-- 
Best regards,
Hans-Christian Noren Egtvedt

  reply	other threads:[~2016-09-18 10:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17 14:56 [PATCH] avr32: fix 'undefined reference to `___copy_from_user' Guenter Roeck
2016-09-17 16:52 ` Håvard Skinnemoen
2016-09-17 20:09   ` Guenter Roeck
2016-09-18  9:46     ` Hans-Christian Noren Egtvedt [this message]
2016-09-18 14:44       ` Guenter Roeck
     [not found] ` <CACiLriRCzX41SWh92cVSjDTKJEDAe+boMNy9JRHp5G9owe48Xw@mail.gmail.com>
2016-09-17 16:53   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160918094643.GA25728@samfundet.no \
    --to=egtvedt@samfundet.no \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.