From: Frederic Weisbecker <fweisbec@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wanpeng Li <wanpeng.li@hotmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers
Date: Sun, 18 Sep 2016 15:35:18 +0200 [thread overview]
Message-ID: <20160918133516.GA5909@lerouge> (raw)
In-Reply-To: <dee8f718-cb9b-4fdc-9226-9fe2a87642cf@redhat.com>
On Fri, Sep 02, 2016 at 04:35:54PM +0200, Paolo Bonzini wrote:
>
>
> On 02/09/2016 16:03, Frederic Weisbecker wrote:
> > static inline unsigned int u64_stats_fetch_begin(const struct u64_stats_sync *syncp)
> > {
> > -#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
> > - return read_seqcount_begin(&syncp->seq);
> > -#else
> > -#if BITS_PER_LONG==32
> > +#if BITS_PER_LONG==32 && !defined(CONFIG_SMP)
> > preempt_disable();
> > +#else
>
> This should be #endif, or this side ends without a "return" statement.
Good catch!
Thanks Paolo!
next prev parent reply other threads:[~2016-09-18 13:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 14:03 [PATCH 0/5] sched/cputime: irqtime cleanups Frederic Weisbecker
2016-09-02 14:03 ` [PATCH 1/5] irqtime: No need for preempt-safe accessors Frederic Weisbecker
2016-09-06 16:59 ` Rik van Riel
2016-09-02 14:03 ` [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update Frederic Weisbecker
2016-09-02 14:53 ` Paolo Bonzini
2016-09-02 16:30 ` Peter Zijlstra
2016-09-06 17:00 ` Rik van Riel
2016-09-07 7:59 ` Peter Zijlstra
2016-09-18 13:47 ` Frederic Weisbecker
2016-09-18 15:54 ` Peter Zijlstra
2016-09-02 14:03 ` [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers Frederic Weisbecker
2016-09-02 14:35 ` Paolo Bonzini
2016-09-18 13:35 ` Frederic Weisbecker [this message]
2016-09-02 14:03 ` [PATCH 4/5] irqtime: Consolidate accounting synchronization with u64_stats API Frederic Weisbecker
2016-09-06 17:03 ` Rik van Riel
2016-09-02 14:03 ` [PATCH 5/5] irqtime: Consolidate irqtime flushing code Frederic Weisbecker
2016-09-06 16:52 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2016-09-26 0:29 [PATCH 0/5] sched/cputime: irqtime cleanups v2 Frederic Weisbecker
2016-09-26 0:29 ` [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918133516.GA5909@lerouge \
--to=fweisbec@gmail.com \
--cc=efault@gmx.de \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.