From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bltWm-0002RL-SJ
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 04:02:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bltWl-0004uS-3N
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 04:02:11 -0400
Date: Mon, 19 Sep 2016 10:01:59 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160919080159.GC4546@noname.redhat.com>
References: <1473982972-8884-1-git-send-email-jsnow@redhat.com>
	<1473982972-8884-3-git-send-email-jsnow@redhat.com>
	<5ece6914-5fa2-bb3a-6e1b-62b6a9ac625a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5ece6914-5fa2-bb3a-6e1b-62b6a9ac625a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] qemu: use bdrv_flush_all for
 vm_stop et al
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org

Am 16.09.2016 um 18:17 hat John Snow geschrieben:
> 
> 
> On 09/15/2016 07:42 PM, John Snow wrote:
> >Bypass the usual check to see if we are "allowed" to flush via the
> >block model, and manually flush the BDS nodes themselves instead.
> >
> >This allows us to do things like migrate when we have a device with
> >an open tray, but has a node that may need to be flushed.
> >
> >Specifically, this allows us to migrate when we have a CDROM with
> >an open tray.
> >
> 
> How about:
> 
> Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all,
> bdrv_flush_all does not have device model restrictions. This allows
> us to flush and halt unconditionally without error.
> 
> This allows us to do things like migrate when we have a device with
> an open tray, but has a node that may need to be flushed

I'd add:

    , or nodes that aren't currently attached to any device and need to
    be flushed.

> Specifically, this allows us to migrate when we have a CDROM with
> an open tray.

Looks good otherwise.

Kevin