Re: [Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state
Message-id: 1474289459-15242-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1474289459-15242-1-git-send-email-pbonzini@redhat.com -> patchew/1474289459-15242-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
8904bcd cpus-common: lock-free fast path for cpu_exec_start/end
70b89fc tcg: Make tb_flush() thread safe
b43cc64 cpus-common: Introduce async_safe_run_on_cpu()
0beae79 cpus-common: simplify locking for start_exclusive/end_exclusive
7781694 cpus-common: remove redundant call to exclusive_idle()
e94de30 cpus-common: always defer async_run_on_cpu work items
cfec378 docs: include formal model for TCG exclusive sections
35a31d5 cpus-common: move exclusive work infrastructure from linux-user
4cf022a cpus-common: fix uninitialized variable use in run_on_cpu
fe02426 cpus-common: move CPU work item management to common code
a8028c5 cpus-common: move CPU list management to common code
c1cd116 linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()
89c728d linux-user: Use QemuMutex and QemuCond
4e0e46c cpus: Rename flush_queued_work()
6dfa694 cpus: Move common code out of {async_, }run_on_cpu()
7959ed8 cpus: pass CPUState to run_on_cpu helpers

=== OUTPUT BEGIN ===
Checking PATCH 1/16: cpus: pass CPUState to run_on_cpu helpers...
Checking PATCH 2/16: cpus: Move common code out of {async_, }run_on_cpu()...
Checking PATCH 3/16: cpus: Rename flush_queued_work()...
Checking PATCH 4/16: linux-user: Use QemuMutex and QemuCond...
Checking PATCH 5/16: linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()...
Checking PATCH 6/16: cpus-common: move CPU list management to common code...
Checking PATCH 7/16: cpus-common: move CPU work item management to common code...
Checking PATCH 8/16: cpus-common: fix uninitialized variable use in run_on_cpu...
Checking PATCH 9/16: cpus-common: move exclusive work infrastructure from linux-user...
Checking PATCH 10/16: docs: include formal model for TCG exclusive sections...
Checking PATCH 11/16: cpus-common: always defer async_run_on_cpu work items...
Checking PATCH 12/16: cpus-common: remove redundant call to exclusive_idle()...
Checking PATCH 13/16: cpus-common: simplify locking for start_exclusive/end_exclusive...
Checking PATCH 14/16: cpus-common: Introduce async_safe_run_on_cpu()...
ERROR: code indent should never use tabs
#68: FILE: cpus-common.c:265:
+^I    /* Running work items outside the BQL avoids the following deadlock:$

ERROR: code indent should never use tabs
#69: FILE: cpus-common.c:266:
+^I     * 1) start_exclusive() is called with the BQL taken while another$

total: 2 errors, 0 warnings, 83 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/16: tcg: Make tb_flush() thread safe...
Checking PATCH 16/16: cpus-common: lock-free fast path for cpu_exec_start/end...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org