Re: [Outreachy kernel] [PATCH] staging: most: hdm-usb: convert pr_warn() to dev_warn()

[Eva Rachel Retuya <eraretuya@gmail.com>]

On Mon, Sep 19, 2016 at 11:56:46AM +0200, Julia Lawall wrote:
> > @a@
> > identifier f, dev;
> > expression fmt, E;
> > @@
> >
> > f(...) {
> > 	...
> > 	struct device *dev = E;
> > 	<+... when != dev == NULL
> > - pr_warn(
> > + dev_warn(dev,
> > 		fmt, ...);
> > 	...+>
> > }
> 
> This is a good idea, but it is unnecessarily inefficient in the details.
> You don't use the function name f, so there is no need to match the entire
> function.  Matching the entire function causes Coccinelle to go through
> all of its possible control-flow paths (loops, conditional branches,
> etc.), which can be expensive.  You can instead just start at struct
> device *dev = E;.  Also, you don't do anything with fmt, so you can drop
> that, and just put ... for the remaining arguments.
> 
> julia

I appreciate the input. I'm going to amend my script according to what
you stated here. Do I have to send v2 for this patch?

Eva