From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759135AbcISM0F (ORCPT ); Mon, 19 Sep 2016 08:26:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbcISMZ6 (ORCPT ); Mon, 19 Sep 2016 08:25:58 -0400 Date: Mon, 19 Sep 2016 14:25:53 +0200 From: Jiri Benc To: Nicolas Pitre Cc: John Stultz , Thomas Gleixner , Richard Cochran , Josh Triplett , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ptp_clock: allow for it to be optional Message-ID: <20160919142553.3fb682ba@griffin> In-Reply-To: <1474257070-4255-2-git-send-email-nicolas.pitre@linaro.org> References: <1474257070-4255-1-git-send-email-nicolas.pitre@linaro.org> <1474257070-4255-2-git-send-email-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 19 Sep 2016 12:25:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Sep 2016 23:51:09 -0400, Nicolas Pitre wrote: > And to make it possible for PTP to be configured out, the select statement > in the Kconfig entry for those ethernet drivers is changed from selecting > PTP_1588_CLOCK to PTP_1588_CLOCK_SELECTED whose purpose is to indicate the > default Kconfig value for the PTP subsystem. With this patch applied, the user is free to set a NIC driver as built in and PTP_1588_CLOCK as a module, right? If so, that would lead to non-functional PTP without any warning due to the use of IS_REACHABLE. That doesn't sound right. Could easily cause hours of headache to someone. Or is this handled somehow? Thanks, Jiri