Re: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build
Message-id: 1474296549-29171-1-git-send-email-berrange@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1474299237-1054-1-git-send-email-berrange@redhat.com -> patchew/1474299237-1054-1-git-send-email-berrange@redhat.com
Switched to a new branch 'test'
439b7d5 trace: introduce a formal group name for trace events
97b7a5f trace: pass trace-events to tracetool as a positional param
46f2527 trace: push reading of events up a level to tracetool main
3f822f1 trace: rename _read_events to read_events
20a8ba2 trace: get rid of generated-events.h/generated-events.c
f6a861d trace: dynamically allocate event IDs at runtime
04e85e1 trace: dynamically allocate trace_dstate in CPUState
5ed1755 trace: provide mechanism for registering trace events
3472cce trace: don't abort qemu if ftrace can't be initialized
e1d4a86 trace: emit name <-> ID mapping in simpletrace header
2270adf trace: remove the TraceEventID and TraceEventVCPUID enums
604483a trace: give each trace event a named TraceEvent struct
731385d trace: break circular dependancy in event-internal.h
34a7e6d trace: remove duplicate control.h includes in generated-tracers.h
6af9de1 trace: remove global 'uint16 dstate[]' array
5c47d07 trace: remove some now unused functions
a222901 trace: convert code to use event iterators
6d86092 trace: add trace event iterator APIs

=== OUTPUT BEGIN ===
Checking PATCH 1/18: trace: add trace event iterator APIs...
Checking PATCH 2/18: trace: convert code to use event iterators...
Checking PATCH 3/18: trace: remove some now unused functions...
Checking PATCH 4/18: trace: remove global 'uint16 dstate[]' array...
WARNING: line over 80 characters
#262: FILE: trace/event-internal.h:24:
+ * Interpretation of @dstate depends on wether the event has the 'vcpu' property:

total: 0 errors, 1 warnings, 211 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/18: trace: remove duplicate control.h includes in generated-tracers.h...
Checking PATCH 6/18: trace: break circular dependancy in event-internal.h...
Checking PATCH 7/18: trace: give each trace event a named TraceEvent struct...
Checking PATCH 8/18: trace: remove the TraceEventID and TraceEventVCPUID enums...
WARNING: line over 80 characters
#168: FILE: trace/control-internal.h:66:
+                                                                 uint32_t vcpu_id)

ERROR: line over 90 characters
#295: FILE: trace/control.h:118:
+    ((id ##_ENABLED) && trace_event_get_vcpu_state_dynamic_by_vcpu_id(vcpu, id ## _EV.vcpu_id))

ERROR: Macros with complex values should be enclosed in parenthesis
#311: FILE: trace/event-internal.h:17:
+#define TRACE_VCPU_EVENT_NONE (uint32_t)-1

WARNING: line over 80 characters
#325: FILE: trace/simple.c:21:
+#define HEADER_EVENT_ID (~(uint64_t)0) /* avoids conflicting with trace event IDs */

total: 2 errors, 2 warnings, 269 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/18: trace: emit name <-> ID mapping in simpletrace header...
ERROR: line over 90 characters
#85: FILE: scripts/simpletrace.py:37:
+    """Deserialize a trace record from a file into a tuple (name, timestamp, pid, arg1, ..., arg6)."""

WARNING: line over 80 characters
#119: FILE: scripts/simpletrace.py:70:
+    return get_record(edict, idtoname, rechdr, fobj) # return tuple of record elements

WARNING: line over 80 characters
#190: FILE: scripts/tracetool/format/simpletrace_stap.py:33:
+        '        printf("%%8b%%8b%%4b%%.*s", 0, event_next_id, name_len, name_len, name)',

ERROR: braces {} are necessary for all arms of this statement
#287: FILE: trace/simple.c:293:
+        if (fwrite(&type, sizeof(type), 1, trace_fp) != 1 ||
[...]

total: 2 errors, 2 warnings, 219 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/18: trace: don't abort qemu if ftrace can't be initialized...
Checking PATCH 11/18: trace: provide mechanism for registering trace events...
Checking PATCH 12/18: trace: dynamically allocate trace_dstate in CPUState...
WARNING: line over 80 characters
#39: FILE: include/qom/cpu.h:353:
+     * Dynamically allocated based on BITS_TO_LONGS(trace_get_vcpu_event_count())

total: 0 errors, 1 warnings, 64 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/18: trace: dynamically allocate event IDs at runtime...
Checking PATCH 14/18: trace: get rid of generated-events.h/generated-events.c...
Checking PATCH 15/18: trace: rename _read_events to read_events...
Checking PATCH 16/18: trace: push reading of events up a level to tracetool main...
Checking PATCH 17/18: trace: pass trace-events to tracetool as a positional param...
Checking PATCH 18/18: trace: introduce a formal group name for trace events...
ERROR: line over 90 characters
#495: FILE: scripts/tracetool/format/ust_events_h.py:31:
+        '#if !defined (TRACE_%s_GENERATED_UST_H) || defined(TRACEPOINT_HEADER_MULTI_READ)' % group.upper(),

total: 1 errors, 0 warnings, 366 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org